Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose scale_factor from iced #234

Merged
merged 3 commits into from
Feb 25, 2024
Merged

expose scale_factor from iced #234

merged 3 commits into from
Feb 25, 2024

Conversation

casperstorm
Copy link
Member

Fixes #233.

@casperstorm casperstorm mentioned this pull request Feb 24, 2024
Closed
tarkah
tarkah approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@tarkah tarkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We may want to add a clamp to ensure it stays within some range, but that's not a blocker

@casperstorm
Copy link
Member Author

LGTM! We may want to add a clamp to ensure it stays within some range, but that's not a blocker

Clamped between 0.1 (as 0.0 and below crashes) and 3.0.

@casperstorm casperstorm merged commit 6c39210 into main Feb 25, 2024
1 check passed
@casperstorm casperstorm deleted the feat/scale branch February 25, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarkah tarkah tarkah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting zoom / font size?
2 participants
@casperstorm @tarkah