-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added notify-away
support
#175
Conversation
39d4d7d
to
c7e6429
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @casperstorm! A couple minor things. Also, we may want to handle RPL_NOWAWAY
and RPL_UNAWAY
so when we issue an /away
command, it'll update our nick in the nicklists. I noticed these are what's sent when we're the ones sending the /away
.
I noticed a message from libera about "rate-limiting" so I'm not sure Maybe we keep track of a map of channels and the last time they're polled for |
This might be because of the WHO being called for all users joining previously. Can you test again? I don't think we have to make a special case for it - doesn't seem others do that 🤔 |
I'm still getting it:
|
Gotcha, yeah let's then add a system which keeps track which we can also use for polling. |
… feat/away-notify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome feature!
This adds support for
notify-away
extension.We call
WHO
when joining a channel to get initial state, and then keeps it synced withAWAY
responses.Away users is appear slightly transparent. This idea is stolen from Textual.