Don't create a new history entry when updating a read marker due to `…

…MARKREAD`; update on disk instead.

data/src/history/manager.rs

@@ -30,6 +30,12 @@ pub enum Message {
         history::Kind,
         Result<history::Metadata, history::Error>,
     ),
+    UpdateReadMarker(
+        server::Server,
+        history::Kind,
+        history::ReadMarker,
+        Result<(), history::Error>,
+    ),
     Closed(
         server::Server,
         history::Kind,
@@ -110,6 +116,14 @@ impl Manager {
             Message::UpdatePartial(server, kind, Err(error)) => {
                 log::warn!("failed to load history metadata for {kind} on {server}: {error}");
             }
+            Message::UpdateReadMarker(server, kind, read_marker, Ok(_)) => {
+                log::debug!("updated read marker for {kind} on {server} to {read_marker}");
+            }
+            Message::UpdateReadMarker(server, kind, read_marker, Err(error)) => {
+                log::warn!(
+                    "failed to update read marker for {kind} on {server} to {read_marker}: {error}"
+                );
+            }
         }
 
         None
@@ -719,20 +733,14 @@ impl Data {
 
                 None
             }
-            hash_map::Entry::Vacant(entry) => {
-                entry
-                    .insert(History::partial(server.clone(), kind.clone()))
-                    .update_read_marker(read_marker);
+            hash_map::Entry::Vacant(_) => Some(
+                async move {
+                    let updated = history::metadata::update(&server, &kind, &read_marker).await;
 
-                Some(
-                    async move {
-                        let loaded = history::metadata::load(server.clone(), kind.clone()).await;
-
-                        Message::UpdatePartial(server, kind, loaded)
-                    }
-                    .boxed(),
-                )
-            }
+                    Message::UpdateReadMarker(server, kind, read_marker, updated)
+                }
+                .boxed(),
+            ),
         }
     }
 

data/src/history/metadata.rs

@@ -85,6 +85,32 @@ pub async fn save(
     Ok(())
 }
 
+pub async fn update(
+    server: &server::Server,
+    kind: &Kind,
+    read_marker: &ReadMarker,
+) -> Result<(), Error> {
+    let metadata = load(server.clone(), kind.clone()).await?;
+
+    if metadata
+        .read_marker
+        .is_some_and(|metadata_read_marker| metadata_read_marker >= *read_marker)
+    {
+        return Ok(());
+    }
+
+    let bytes = serde_json::to_vec(&Metadata {
+        read_marker: Some(*read_marker),
+        last_triggers_unread: metadata.last_triggers_unread,
+    })?;
+
+    let path = path(server, kind).await?;
+
+    fs::write(path, &bytes).await?;
+
+    Ok(())
+}
+
 async fn path(server: &server::Server, kind: &Kind) -> Result<PathBuf, Error> {
     let dir = dir_path().await?;