Expose opentracing start span options to allow tag customization #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryho
approved these changes
Feb 20, 2024
msquaredh
approved these changes
Feb 20, 2024
danrice67
reviewed
Feb 20, 2024
db.go
Outdated
| // SetStartSpanOption will apply the span option function to every opentracing span created by squalor | ||
| func SetStartSpanOption(spanOption opentracing.StartSpanOption) DBOption { | ||
| return func(db *DB) error { | ||
| if db.SpanOptions == nil { |
There was a problem hiding this comment.
You don't need the if since append will create the slice if needed
There was a problem hiding this comment.
You could also make this function take varargs ...opentracing.StartSpanOption and append them all
There was a problem hiding this comment.
Good idea - fixed
danrice67
reviewed
Feb 20, 2024
db.go
Outdated
| models map[reflect.Type]*Model | ||
| mappings map[reflect.Type]fieldMap | ||
| // Span option functions are applied to every span started by squalor, when OpentracingEnabled is true. | ||
| SpanOptions []opentracing.StartSpanOption |
There was a problem hiding this comment.
Does this need to be visible (capitalized)?
There was a problem hiding this comment.
nope - made private
danrice67
reviewed
Feb 20, 2024
db.go
Outdated
| @@ -513,6 +526,7 @@ func NewDB(db *sql.DB, options ...DBOption) (*DB, error) { | |||
| IgnoreMissingCols: false, | |||
| Logger: nil, | |||
| OpentracingEnabled: false, | |||
| SpanOptions: make([]opentracing.StartSpanOption, 0), | |||
There was a problem hiding this comment.
Could probably initialize to nil just fine
gruane-sq
force-pushed
the
start-span-option
branch
from
5cd1a1b
to
51faa3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the
opentracing.StartSpanOptionto allow callers to pass custom span tags. One use case is to allow control over Datadog's Unified Span Tagging. This is commonly done with database clients so that queries show as a different "service" in the Datadog interface, with their own Service Page that is tailored specifically to database interactions.