Update to rule permalinks #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alanmcruickshank Sounds good, let me know when you want this merged/released and I can do that |
|
Let's merge it now, but then release shortly after we get the SQLFluff release out. I'll stage that today, and then hopefully get it shipped tomorrow. |
|
@RobertOstermann I've just shipped the relevant core sqlfluff release. Any chance you could cut a new release for the VSCode plugin fairly soon? That will prevent anyone raising a bug over the links not working anymore. |
|
@alanmcruickshank Publishing now with v3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because of sqlfluff/sqlfluff#6052 (which broke the current links) and relies on sqlfluff/sqlfluff#6066 (to enable rule permalinks).
We should probably do a coordinated release of both the plugin and SQLFluff core so these go live at roughly the same moment. I'm likely to do a SQLFluff release later this week so that might be a good moment.