Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datacoves' dbt-core-interface improvements + new response #144

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Datacoves' dbt-core-interface improvements + new response #144

merged 4 commits into from
Jul 19, 2024

Conversation

BAntonellini
Copy link
Contributor

  • Various dbt-core-interface improvements in terms of code clarity.
  • Added response when .sqlfluff file is broken (Unfixable, unlintable)

@BAntonellini
Copy link
Contributor Author

Hey @RobertOstermann, could you review this? Thanks!

RobertOstermann
RobertOstermann approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@RobertOstermann RobertOstermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge whenever you are ready

@BAntonellini
Copy link
Contributor Author

@RobertOstermann I don't have access to do so.

@RobertOstermann RobertOstermann merged commit d8d4f22 into sqlfluff:master Jul 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertOstermann RobertOstermann RobertOstermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BAntonellini @RobertOstermann