Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing Links #145

Merged
merged 13 commits into from
Jul 19, 2023
Merged

Sharing Links #145

merged 13 commits into from
Jul 19, 2023

Conversation

skgbafa
Copy link
Contributor

@skgbafa skgbafa commented Jul 19, 2023

Description

Add support for Sharing links with the KeplerStorage module

Type

  • New feature (non-breaking change which adds functionality)

Diligence Checklist

  • I added a changelog with all changes I made in this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have updated and/or included unit tests
  • I have updated and/or included new end-to-end tests
  • I have made corresponding changes to the documentation (if required)
  • Any dependent changes have been merged and published in downstream modules

@skgbafa skgbafa requested a review from Juliano1612 July 19, 2023 05:24
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Patch coverage: 31.79% and project coverage change: -1.88 ⚠️

Comparison is base (5b8bbde) 81.43% compared to head (117394d) 79.56%.

❗ Current head 117394d differs from pull request most recent head 7998c5d. Consider uploading reports for the commit 7998c5d to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           v2.0.0-beta     #145      +/-   ##
===============================================
- Coverage        81.43%   79.56%   -1.88%     
===============================================
  Files               34       34              
  Lines             4250     4355     +105     
  Branches           245      245              
===============================================
+ Hits              3461     3465       +4     
- Misses             789      890     +101     
Impacted Files Coverage Δ
...kages/ssx-sdk/src/modules/Storage/KeplerStorage.ts 25.79% <22.67%> (-3.29%) ⬇️
packages/ssx-core/src/client/types.ts 100.00% <100.00%> (ø)
packages/ssx-sdk/src/modules/Storage/interfaces.ts 100.00% <100.00%> (ø)
...sx-sdk/src/modules/Storage/kepler/authenticator.ts 29.62% <100.00%> (-1.70%) ⬇️
...ckages/ssx-sdk/src/modules/Storage/kepler/index.ts 100.00% <100.00%> (ø)
...kages/ssx-sdk/src/modules/Storage/kepler/kepler.ts 58.22% <100.00%> (-0.53%) ⬇️
...ckages/ssx-sdk/src/modules/Storage/kepler/orbit.ts 58.82% <100.00%> (-0.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Juliano1612 Juliano1612 changed the base branch from v2.0.0-beta to main July 19, 2023 15:23
@CLAassistant
Copy link

CLAassistant commented Jul 19, 2023

CLA assistant check
All committers have signed the CLA.

@w4ll3 w4ll3 self-requested a review July 19, 2023 15:51
@Juliano1612 Juliano1612 merged commit c93118a into spruceid:main Jul 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants