Add SupplierClientRegistrationRepository
#12972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
justin-tay
force-pushed
the
supplier-client-repo
branch
from
e2c1614
to
85f9f29
Compare
marcusdacoregio
added
type: enhancement
jzheaux
requested changes
May 15, 2023
There was a problem hiding this comment.
Thanks for the PR, @justin-tay! I've left some feedback inline.
...pringframework/security/oauth2/client/registration/SupplierClientRegistrationRepository.java
Outdated
Show resolved
Hide resolved
...pringframework/security/oauth2/client/registration/SupplierClientRegistrationRepository.java
Outdated
Show resolved
Hide resolved
...pringframework/security/oauth2/client/registration/SupplierClientRegistrationRepository.java
Outdated
Show resolved
Hide resolved
justin-tay
force-pushed
the
supplier-client-repo
branch
3 times, most recently
from
63fadd8
to
0187afd
Compare
jzheaux
added
status: duplicate
justin-tay
force-pushed
the
supplier-client-repo
branch
2 times, most recently
from
311998c
to
994069a
Compare
jzheaux
requested changes
Jun 22, 2023
There was a problem hiding this comment.
My apologies, @justin-tay, it looks like my latest review was still pending. I'm publishing it now and look forward to any updates.
...pringframework/security/oauth2/client/registration/SupplierClientRegistrationRepository.java
Outdated
Show resolved
Hide resolved
justin-tay
force-pushed
the
supplier-client-repo
branch
2 times, most recently
from
8716428
to
1bc6fd5
Compare
jzheaux
approved these changes
Jul 12, 2023
jzheaux
force-pushed
the
supplier-client-repo
branch
from
1bc6fd5
to
9f56928
Compare
|
Thanks, @justin-tay! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-12967
Adds a
SupplierClientRegistrationRepositoryto lazily retrieveClientRegistration(s).This is different from the proposed design and instead each registration can be lazily retrieved. If caching is required a
SingletonSuppliercan be used.