Skip to content

Commit

Permalink
GH-815 - Fix and improve Kotlin code examples in reference documentat…
Browse files Browse the repository at this point in the history
…ion.
  • Loading branch information
Nils Breunese authored and odrotbohm committed Sep 12, 2024
1 parent 354a4c6 commit 13d7618
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 25 deletions.
4 changes: 2 additions & 2 deletions src/docs/antora/modules/ROOT/pages/documentation.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Kotlin::
[source, kotlin, role="secondary"]
----
class DocumentationTests {
private val modules = ApplicationModules.of(Application::class)
private val modules = ApplicationModules.of(Application::class.java)
@Test
fun writeDocumentationSnippets() {
Expand Down Expand Up @@ -238,7 +238,7 @@ Kotlin::
----
class DocumentationTests {
private val modules = ApplicationModules.of(Application::class)
private val modules = ApplicationModules.of(Application::class.java)
@Test
fun writeDocumentationSnippets() {
Expand Down
10 changes: 5 additions & 5 deletions src/docs/antora/modules/ROOT/pages/events.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ class ExternalizationConfiguration {

return EventExternalizationConfiguration.externalizing() // <1>
.select(EventExternalizationConfiguration.annotatedAsExternalized()) // <2>
.mapping(SomeEvent.class, it -> …) // <3>
.mapping(SomeEvent.class, event -> …) // <3>
.routeKey(WithKeyProperty.class, WithKeyProperty::getKey) // <4>
.build();
}
Expand All @@ -443,8 +443,8 @@ class ExternalizationConfiguration {

EventExternalizationConfiguration.externalizing() // <1>
.select(EventExternalizationConfiguration.annotatedAsExternalized()) // <2>
.mapping(SomeEvent::class, it -> …) // <3>
.routeKey(WithKeyProperty::class, WithKeyProperty::getKey) // <4>
.mapping(SomeEvent::class.java) { event -> … } // <3>
.routeKey(WithKeyProperty::class.java, WithKeyProperty::getKey) // <4>
.build()
}
}
Expand Down Expand Up @@ -501,7 +501,7 @@ class OrderIntegrationTests {
fun someTestMethod(events: PublishedEvents events) {

// …
var matchingMapped = events.ofType(OrderCompleted::class)
val matchingMapped = events.ofType(OrderCompleted::class.java)
.matching(OrderCompleted::getOrderId, reference.getId())

assertThat(matchingMapped).hasSize(1)
Expand Down Expand Up @@ -546,7 +546,7 @@ class OrderIntegrationTests {

// …
assertThat(events)
.contains(OrderCompleted::class)
.contains(OrderCompleted::class.java)
.matching(OrderCompleted::getOrderId, reference.getId())
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/docs/antora/modules/ROOT/pages/fundamentals.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ Kotlin::
+
[source, kotlin, role="secondary"]
----
var modules = ApplicationModules.of(Application::class)
var modules = ApplicationModules.of(Application::class.java)
----
======
To get an impression of what the analyzed arrangement looks like, we can just write the individual modules contained in the overall model to the console:
Expand Down
32 changes: 16 additions & 16 deletions src/docs/antora/modules/ROOT/pages/testing.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ Kotlin::
scenario.publish(MyApplicationEvent(…)).…
// Start with a bean invocation
scenario.stimulate(() -> someBean.someMethod(…)).…
scenario.stimulate(Runnable { someBean.someMethod(…) }).…
----
======

Expand Down Expand Up @@ -263,9 +263,9 @@ Kotlin::
[source, kotlin, role="secondary"]
----
scenario.publish(new MyApplicationEvent(…))
.andWaitForEventOfType(SomeOtherEvent::class)
.matching(event -> …)
.toArriveAndVerify(event -> …)
.andWaitForEventOfType(SomeOtherEvent::class.java)
.matching { event -> … }
.toArriveAndVerify { event -> … }
----
======

Expand All @@ -287,9 +287,9 @@ Kotlin::
+
[source, kotlin, role="secondary"]
----
scenario.publish(new MyApplicationEvent(…))
.andWaitForStateChange(() -> someBean.someMethod(…)))
.andVerify(result -> …)
scenario.publish(MyApplicationEvent(…))
.andWaitForStateChange { someBean.someMethod(…) }
.andVerify { result -> … }
----
======

Expand All @@ -310,7 +310,7 @@ Java::
[source, java, subs="+quotes", role="primary"]
----
scenario.publish(new MyApplicationEvent(…))
**.customize(it -> it.atMost(Duration.ofSeconds(2)))**
**.customize(conditionFactory -> conditionFactory.atMost(Duration.ofSeconds(2)))**
.andWaitForEventOfType(SomeOtherEvent.class)
.matching(event -> …)
.toArriveAndVerify(event -> …);
Expand All @@ -320,10 +320,10 @@ Kotlin::
[source, kotlin, subs="+quotes", role="secondary"]
----
scenario.publish(MyApplicationEvent(…))
**.customize(it -> it.atMost(Duration.ofSeconds(2)))**
.andWaitForEventOfType(SomeOtherEvent::class)
.matching(event -> …)
.toArriveAndVerify(event -> …)
**.customize { it.atMost(Duration.ofSeconds(2)) }**
.andWaitForEventOfType(SomeOtherEvent::class.java)
.matching { event -> … }
.toArriveAndVerify { event -> … }
----
======

Expand All @@ -348,7 +348,7 @@ class MyTests {
@Override
Function<ConditionFactory, ConditionFactory> getDefaultCustomizer(Method method, ApplicationContext context) {
return it -> …;
return conditionFactory -> …;
}
}
}
Expand All @@ -361,14 +361,14 @@ Kotlin::
class MyTests {
@Test
fun myTestCase(scenario : Scenario) {
fun myTestCase(scenario: Scenario) {
// scenario will be pre-customized with logic defined in MyCustomizer
}
class MyCustomizer : ScenarioCustomizer {
override fun getDefaultCustomizer(method : Method, context : ApplicationContext) : Function<ConditionFactory, ConditionFactory> {
return it -> …
override fun getDefaultCustomizer(method: Method, context: ApplicationContext): UnaryOperator<ConditionFactory> {
return UnaryOperator { conditionFactory -> … }
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/docs/antora/modules/ROOT/pages/verification.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Kotlin::
+
[source, kotlin, role="secondary"]
----
ApplicationModules.of(Application::class).verify()
ApplicationModules.of(Application::class.java).verify()
----
======
The verification includes the following rules:
Expand Down

0 comments on commit 13d7618

Please sign in to comment.