GH-2974 Add NonNullApi and NonNullFields to package-info.java in 'annotation' package #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanQingyangXu
changed the title
| traverse = Objects.requireNonNullElseGet( | ||
| traverseResolved, | ||
| () -> !includes.isEmpty() || !excludes.isEmpty() | ||
| ); |
There was a problem hiding this comment.
the above change is suggested by IDEA. Let me know whether we are happy with the change and I can revert back to old state.
| @@ -349,7 +363,8 @@ else if (resolved != null) { | |||
| private List<Class<? extends Throwable>> resolveClasses(Class<? extends Throwable>[] fromAnnot, String[] names, | |||
| String type) { | |||
|
|
|||
| List<Class<? extends Throwable>> classes = new ArrayList<>(Arrays.asList(fromAnnot)); | |||
| List<Class<? extends Throwable>> classes = new ArrayList<>(fromAnnot.length + names.length); | |||
| Collections.addAll(classes, fromAnnot); | |||
There was a problem hiding this comment.
the above changes tries to improve on:
- code readability (the double list wrapper makes code reader's head spin a lot)
- a little bit perf opt (super minor; JMH shows it boosts perf by 100%)
Again, let me know whether we need to do this in the first place
NathanQingyangXu
force-pushed
the
add-nonnullapi-to-annotation-package
branch
from
f197f47
to
de1b435
Compare
NathanQingyangXu
force-pushed
the
add-nonnullapi-to-annotation-package
branch
from
de1b435
to
57d8ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
almost all of the nullness vulnerability has been fixed except that gigantic
org.springframework.kafka.annotation.KafkaListenerAnnotationBeanPostProcessorclass, which is left for future PR(s).