Skip to content

Commit

Permalink
Support instantiation of Kotlin class with overridden read-only prope…
Browse files Browse the repository at this point in the history
…rty.

Closes: #4485
Original Pull Request: #4777
  • Loading branch information
mp911de authored and christophstrobl committed Sep 10, 2024
1 parent 9afa237 commit 7d3c6ea
Show file tree
Hide file tree
Showing 3 changed files with 70 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,8 @@ private <S> S populateProperties(ConversionContext context, MongoPersistentEntit
MongoDbPropertyValueProvider valueProvider = new MongoDbPropertyValueProvider(contextToUse, documentAccessor,
evaluator, spELContext);

Predicate<MongoPersistentProperty> propertyFilter = isIdentifier(entity).or(isConstructorArgument(entity)).negate();
Predicate<MongoPersistentProperty> propertyFilter = isIdentifier(entity).or(isConstructorArgument(entity))
.or(Predicates.negate(PersistentProperty::isReadable)).negate();
readProperties(contextToUse, entity, accessor, documentAccessor, valueProvider, evaluator, propertyFilter);

return accessor.getBean();
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/*
* Copyright 2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.data.mongodb.core.convert

import org.assertj.core.api.Assertions.assertThat
import org.bson.Document
import org.junit.jupiter.api.Test
import org.springframework.data.mongodb.core.mapping.MongoMappingContext

/**
* Kotlin unit tests for [MappingMongoConverter].
*
* @author Mark Paluch
*/
class MappingMongoConverterKtUnitTests {

@Test // GH-4485
fun shouldIgnoreNonReadableProperties() {

val document = Document.parse("{_id: 'baz', type: 'SOME_VALUE'}")
val converter =
MappingMongoConverter(NoOpDbRefResolver.INSTANCE, MongoMappingContext())

val tx = converter.read(SpecialTransaction::class.java, document)

assertThat(tx.id).isEqualTo("baz")
assertThat(tx.type).isEqualTo("SOME_DEFAULT_VALUE")
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/*
* Copyright 2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.data.mongodb.core.convert

abstract class SomeTransaction() {

abstract val id: String
abstract val type: String
}

data class SpecialTransaction(override val id: String) : SomeTransaction() {
override val type: String = "SOME_DEFAULT_VALUE"
}

0 comments on commit 7d3c6ea

Please sign in to comment.