Move RepositoryMethodContext to repository.core package
#3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Oct 15, 2024
...java/org/springframework/data/repository/config/RepositoryConfigurationExtensionSupport.java
Outdated
Show resolved
Hide resolved
odrotbohm
force-pushed
the
feature/3175
branch
from
520ee96
to
203074a
Compare
| RepositoryConfigurationSource configurationSource) { | ||
|
|
||
| // A proxy RepositoryMethodContext for dependency injection | ||
| registerIfNotAlreadyRegistered( |
There was a problem hiding this comment.
Instance supplier is not supported in AOT and will raise org.springframework.beans.factory.aot.AotBeanProcessingException.
| * | ||
| * @return will never be {@literal null}. | ||
| */ | ||
| public static RepositoryMethodContext getInjectionProxy() { |
There was a problem hiding this comment.
we'll need additional native image proxy configuration for RepositoryMethodContext.
christophstrobl
force-pushed
the
feature/3175
branch
from
203074a
to
3e80b97
Compare
mp911de
changed the title
RepositoryMethodContextRepositoryMethodContext to repository.core package
RepositoryMethodContext are now made available for dependency injection via RepositoryConfigurationExtensionSupport.registerBeansForRoot(…). Moved RMC into repository.core package (previously repository.core.support) and only expose factory methods on DefaultRepositoryMethodContext. DRMC also exposes a injection proxy lookup method that creates a proxy equipped with a TargetSource delegating to DRMC.getInstance() (previously ….getContext()). An additional, static DRMC.forMethod(…) allows the creation of a default instance for testing purposes. Rename getRepository() to getMetadata() on RMC. Fixes GH-3175.
mp911de
force-pushed
the
feature/3175
branch
2 times, most recently
from
be34301
to
5cd4d5d
Compare
Avoid nullability in RepositoryMethodContextHolder.getContext(). Introduce shortcut in RepositoryMethodContext to obtain the current thread-local context. Update documentation.
mp911de
pushed a commit
that referenced
this pull request
Oct 16, 2024
RepositoryMethodContext are now made available for dependency injection via RepositoryConfigurationExtensionSupport.registerBeansForRoot(…). Moved RMC into repository.core package (previously repository.core.support) and only expose factory methods on DefaultRepositoryMethodContext. DRMC also exposes a injection proxy lookup method that creates a proxy equipped with a TargetSource delegating to DRMC.getInstance() (previously ….getContext()). An additional, static DRMC.forMethod(…) allows the creation of a default instance for testing purposes. Rename getRepository() to getMetadata() on RMC. Fixes #3175. Original pull request: #3176
|
Thank you for your contribution. That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in the commit message.