-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OAuth2EndpointUtils.java #1728
Conversation
getQueryParameters only get query parameter , getFormParameters only get form parameter
@MicahZheng I don't understand why this change is needed? Did you find an issue? If so, please provide a minimal sample or test that reproduces the issue so I can look into it further. |
When the query parameters and form parameters are the same, the method getFormParameters will not get any parameters. And my partner gave me such parameters when requesting my interface, and the query parameters and form parameters are exactly the same. It does provide enough parameters. Maybe he should only put the form parameters, but I found that the method getQueryParameters and the method getFormParameters are not Just get the corresponding content like his name |
@MicahZheng Sorry but I still don't understand your use case. As mentioned in the previous comment:
This will help me understand your use case. As of now, I don't see any issues and this PR will get closed if you're unable to provide a reproducer. |
POST https://example.com/oauth2/token?grant_type=authorization_code&code=the_authorization_code&redirect_uri=https%3A%2F%2Fyourapp.com%2Fcallback&client_id=client_id&client_secret=client_secret&scope=read+write HTTP/1.1 grant_type=authorization_code&code=the_authorization_code&redirect_uri=https%3A%2F%2Fyourapp.com%2Fcallback&client_id=client_id&client_secret=client_secret&scope=read+write |
@MicahZheng I now understand your scenario. Please review the spec for Token Endpoint:
The client should not be sending query parameters AND body parameters as this is an invalid request and should be fixed at the client. I'm going to close this PR as |
getQueryParameters only get query parameter ,
getFormParameters only get form parameter