Skip to content

Commit

Permalink
Udate onnx-runtime to 1.19.2 and djl to 0.29.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@tzolov
tzolov committed Sep 11, 2024
1 parent 0041afa commit df17f08
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,8 @@
<awssdk.version>2.26.7</awssdk.version>

<jackson.version>2.16.1</jackson.version>
<djl.version>0.28.0</djl.version>
<onnxruntime.version>1.18.0</onnxruntime.version>
<djl.version>0.29.0</djl.version>
<onnxruntime.version>1.19.2</onnxruntime.version>
<com.google.cloud.version>26.41.0</com.google.cloud.version>
<qdrant.version>1.9.1</qdrant.version>
<spring-retry.version>2.0.5</spring-retry.version>
Expand Down

3 comments on commit df17f08

@fjtorres
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tzolov, thank you for your great job with spring-ai. Just a comment about this change. This version of DJL is making impossible to use PyTorch in MacOS x86_64 systems. This is because of this: pytorch/pytorch#114602

I am using spring-ai for a while and today I was just creating a new test project to test topic modeling. It was not possible to run it because of the lack of support of PyTorch in my laptop. Are you aware of that impact?

@tzolov
Copy link
Contributor Author

@tzolov tzolov commented on df17f08 Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fjtorres,
The pytorch/pytorch#114602 clearly deprecates the MacOs x86 builds for good.
Unless DJL do something to provide backward compatibility I'm not sure if there is anything spring-ai can do. Soon or later we will have to upgrade the DJL dependency.

Is this DJL issue somewhat related: deepjavalibrary/djl#3414 ? Apparently DJL released 0.30.0 and I just updated our snapshot version accordingly.
Please give it a try. If it still doesn't work perhaps you can downgrade your djl dependencies using maven exclusion? E.g.

		<dependency>
			<groupId>org.springframework.ai</groupId>
			<artifactId>spring-ai-transformers-spring-boot-starter</artifactId>
			<exclusions>
				<exclusion>
					<groupId>ai.djl.pytorch</groupId>
					<artifactId>pytorch-engine</artifactId>
				</exclusion>
				<exclusion>
					<groupId>ai.djl</groupId>
					<artifactId>api</artifactId>
				</exclusion>
				<exclusion>
					<groupId>ai.djl</groupId>
					<artifactId>model-zoo</artifactId>
				</exclusion>
				<exclusion>
					<groupId>ai.djl.huggingface</groupId>
					<artifactId>tokenizers</artifactId>
				</exclusion>

			</exclusions>
		</dependency>

		<dependency>
			<groupId>ai.djl.pytorch</groupId>
			<artifactId>pytorch-engine</artifactId>
			<version>0.28.0</version>
		</dependency>
		<dependency>
			<groupId>ai.djl</groupId>
			<artifactId>api</artifactId>
			<version>0.28.0</version>
		</dependency>
		<dependency>
			<groupId>ai.djl</groupId>
			<artifactId>model-zoo</artifactId>
			<version>0.28.0</version>
		</dependency>
		<dependency>
			<groupId>ai.djl.huggingface</groupId>
			<artifactId>tokenizers</artifactId>
			<version>0.28.0</version>
		</dependency>

Can you also raise the PyTorch in MacOS x86_64 problem as an DJL GH issues? Let see what they would advise?

@tzolov
Copy link
Contributor Author

@tzolov tzolov commented on df17f08 Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for tracking: #1371

Please sign in to comment.