Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

allow ssm:GetParameter with ssm config #61

Open
moritzzimmer opened this issue Jul 1, 2020 · 1 comment · Fixed by moritzzimmer/terraform-aws-lambda#3
Open

allow ssm:GetParameter with ssm config #61

moritzzimmer opened this issue Jul 1, 2020 · 1 comment · Fixed by moritzzimmer/terraform-aws-lambda#3
Assignees
@moritzzimmer
Labels
bug Something isn't working

Comments

@moritzzimmer
Copy link
Contributor

Currently this module configures the following policy for ssm_parameter_names:

data "aws_iam_policy_document" "ssm_policy_document" {
  count = length(var.ssm_parameter_names)

  statement {
    actions = [
      "ssm:GetParameters",
      "ssm:GetParametersByPath",
    ]

    resources = [
      "arn:aws:ssm:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:parameter/${element(var.ssm_parameter_names, count.index)}",
    ]
  }
}

This datasource should also permit ssm:GetParameter.
@moritzzimmer moritzzimmer added the bug Something isn't working label Jul 1, 2020
@moritzzimmer moritzzimmer self-assigned this Jul 1, 2020
@moritzzimmer moritzzimmer changed the title allow ssm:GetParameters with ssm config allow ssm:GetParameter with ssm config Jul 1, 2020
moritzzimmer added a commit to moritzzimmer/terraform-aws-lambda that referenced this issue Aug 28, 2020
@moritzzimmer
new configuration for ssm
c7cc971 
- custom object which can be enhanced for kms_key later
- adapted documentation and added example
- allow `ssm:GetParameter`

for spring-media users, this fixes spring-media/terraform-aws-lambda#61 and spring-media/terraform-aws-lambda#59
@moritzzimmer moritzzimmer mentioned this issue Aug 28, 2020
Merged
moritzzimmer added a commit to moritzzimmer/terraform-aws-lambda that referenced this issue Aug 28, 2020
@moritzzimmer
Refactoring of SSM configuration (#3)
156ee79 
* streamlined tests and variables

- use objects in favour of maps to have a more precise API and documentation (those are interchangeable from a client perspective)
- use lambda fixture in all tests
- streamlined examples
- added deprecation comments for ssm
- use `kms_key_arn` (also) as described in https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_function#kms_key_arn

* new configuration for ssm

- custom object which can be enhanced for kms_key later
- adapted documentation and added example
- allow `ssm:GetParameter`

for spring-media users, this fixes spring-media/terraform-aws-lambda#61 and spring-media/terraform-aws-lambda#59
@moritzzimmer moritzzimmer reopened this Aug 29, 2020
@moritzzimmer
Copy link
Contributor Author

this is fixed with https://github.com/moritzzimmer/terraform-aws-lambda/releases/tag/v5.4.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@moritzzimmer moritzzimmer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring of SSM configuration moritzzimmer/terraform-aws-lambda
1 participant
@moritzzimmer