Refactoring of SSM configuration #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use objects in favour of maps to have a more precise API and documentation (those are interchangeable from a client perspective) - use lambda fixture in all tests - streamlined examples - added deprecation comments for ssm - use `kms_key_arn` (also) as described in https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_function#kms_key_arn
- custom object which can be enhanced for kms_key later - adapted documentation and added example - allow `ssm:GetParameter` for spring-media users, this fixes spring-media/terraform-aws-lambda#61 and spring-media/terraform-aws-lambda#59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new configuration object
ssmto specify SSM parameter names. The IAM role will be enhanced with read permissions to those parameters.In addition the variable
kms_key_arnwill (also) be set in theaws_lambda_functionas described in https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_function#kms_key_arn.(for spring-media users, this fixes spring-media/terraform-aws-lambda#61 and spring-media/terraform-aws-lambda#59)
Deprecations:
ssm_parameter_namesvariable is deprecated and scheduled for deletion in the next major release of this modulekms_key_arnto create an IAM role attachment to allowkms:Decryptfor custom keys is deprecated and will be removed in the next major release of this module