Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Spring RestClient as TransportClientFactory #4281
base: main
Are you sure you want to change the base?
Support Spring RestClient as TransportClientFactory #4281
Changes from 4 commits
0a88c0f
783d4c1
142f1af
a9c6260
760dae3
1084cbc
b2c98b6
a6c2690
a9f8a23
6fd4f58
0ea8039
ac24e37
4c7ce21
871451c
e239d9b
8abfc6d
8581ab0
ffcff5d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some more consideration, I actually think we could switch to using
RestClient
by default in case of the non-blocking stack, so let's addmatchIfMissing=true
and@ConditionalOnProperty(prefix = "eureka.client", name = "restclient.enabled", havingValue = "false")
to theRestTemplate
-based configuration. Sorry for the confusion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some more consideration, I actually think we could switch to using
RestClient
by default in case of the non-blocking stack, so let's addmatchIfMissing=true
and@ConditionalOnProperty(prefix = "eureka.client", name = "restclient.enabled", havingValue = "false")
to theRestTemplate
-based configuration. Sorry for the confusion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added related conditions while changing
JerseyClientNotPresentOrNotEnabledCondition
toRestTemplateEnabledCondition
. Is this what you intended? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the logic after your changes has been modified - please take a look at the review comments.