-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API endpoints, Migrate PR #168 from 2-4-stable to 3-0-stable #177
base: 3-0-stable
Are you sure you want to change the base?
Conversation
basically just takes what the regular spree version does and lets you do it passing json also made simple poro model for returning the url to redirect to on paypal Conflicts: spree_paypal_express.gemspec
Travis fails with the same error reported in #176, at least is consistent. The failure is not related at all with the changes of this PR. |
What's the latest on this @givanse ? |
We should look at taking this logic for the API instead and putting it along with spree/spree_gateway#232 |
The PR is complete, but its blocked by #176 |
@givanse - I'm trying to use this code in my project. Can you point me to documentation on how the API requests / responses should look for this PR? Something like this walkthrough would be great: |
I never got this branch to work (see #176). I went with 2-4-stable. When I was working with this gem I was building an Ember app, the addon I used for it is here: https://github.com/aethermx/spree-ember-paypal-express That repo should give you an idea of how the frontend is talking to the backend. It feels like this was ages ago. If that addon is of no help, feel free to ping me again. |
Migrate PR #168 from
2-4-stable
to3-0-stable
.I had 1 local failure, but I don't think is related to any of the PR changes. See: #176 Maybe Travis results will come up fine.