Skip to content

Commit

Permalink
remove module, embrace components
Browse files Browse the repository at this point in the history
  • Loading branch information
gaetancollaud committed Feb 8, 2024
1 parent 232d520 commit 62b257a
Show file tree
Hide file tree
Showing 17 changed files with 100 additions and 166 deletions.
19 changes: 17 additions & 2 deletions frontend/src/app/app.component.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import {Component} from '@angular/core';
import {Router} from '@angular/router';
import {Router, RouterLink, RouterLinkActive, RouterOutlet} from '@angular/router';
import {CommonModule} from '@angular/common';
import {MatTabNav, MatTabNavPanel, MatTabsModule} from '@angular/material/tabs';
import {MatToolbar, MatToolbarModule} from '@angular/material/toolbar';

interface Link {
path: string;
Expand All @@ -8,8 +11,20 @@ interface Link {

@Component({
selector: 'app-root',
standalone: true,
templateUrl: './app.component.html',
styleUrl: './app.component.scss'
styleUrl: './app.component.scss',
imports: [
CommonModule,


RouterLink,
RouterLinkActive,
RouterOutlet,

MatTabsModule,
MatToolbar
],
})
export class AppComponent {
navLinks: Link[] = [
Expand Down
9 changes: 8 additions & 1 deletion frontend/src/app/app.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@ import {provideRouter} from '@angular/router';

import {routes} from './app.routes';
import {provideAnimations} from '@angular/platform-browser/animations';
import {provideHttpClient} from '@angular/common/http';
import {provideGraphql} from './graphql-provider';

export const appConfig: ApplicationConfig = {
providers: [provideRouter(routes), provideAnimations()]
providers: [
provideRouter(routes),
provideAnimations(),
provideHttpClient(),
provideGraphql()
],
};
34 changes: 0 additions & 34 deletions frontend/src/app/app.module.ts

This file was deleted.

38 changes: 0 additions & 38 deletions frontend/src/app/common/material.module.ts

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import generatedFragments from '../generated/graphql/fragments';
import {NgModule} from '@angular/core';
import {Provider} from '@angular/core';
import {Apollo, APOLLO_OPTIONS} from 'apollo-angular';
import {ApolloClientOptions, createHttpLink, InMemoryCache} from '@apollo/client/core';
import {APOLLO_OPTIONS, ApolloModule} from 'apollo-angular';
import {setContext} from '@apollo/client/link/context';
import generatedFragments from '../generated/graphql/fragments';


const httpLink = createHttpLink({
uri: '/graphql',
Expand Down Expand Up @@ -35,20 +36,17 @@ export function createApollo(): ApolloClientOptions<any> {
};
}

@NgModule({
imports: [
ApolloModule
],
providers: [
export function provideGraphql(): Provider[] {
return [

{
provide: APOLLO_OPTIONS,
useFactory: createApollo,
deps: [],
},
],
})
export class GraphQLModule {
constructor() {

}
{
provide: Apollo,
useClass: Apollo
}
];
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,21 @@ import {AfterViewInit, Component, OnInit, ViewChild} from '@angular/core';
import {GetContextDatasGQL} from '../../../generated/graphql/sdk';
import {ContextDataEntity} from '../../../generated/graphql/types';
import {LiveAnnouncer} from '@angular/cdk/a11y';
import {MatSort, Sort} from '@angular/material/sort';
import {MatTableDataSource} from '@angular/material/table';
import {MatSort, MatSortModule, Sort} from '@angular/material/sort';
import {MatTable, MatTableDataSource, MatTableModule} from '@angular/material/table';
import {MatSnackBar} from '@angular/material/snack-bar';
import {MapDisplayComponent} from '../../common/map-display/map-display.component';

@Component({
standalone: true,
selector: 'app-context-data-list',
templateUrl: './context-data-list.component.html',
styleUrl: './context-data-list.component.scss'
styleUrl: './context-data-list.component.scss',
imports: [
MapDisplayComponent,
MatTableModule,
MatSortModule
]
})
export class ContextDataListComponent implements OnInit, AfterViewInit {

Expand Down
14 changes: 6 additions & 8 deletions frontend/src/app/tab-context-data/tab-context-data.module.ts
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
import {NgModule} from '@angular/core';
import {CommonModule} from '@angular/common';
import {ContextDataListComponent} from './context-data-list/context-data-list.component';
import {MaterialModule} from '../common/material.module';
import {RouterModule} from '@angular/router';
import {routes} from './tab-context-data.route';
import {ContextDataListComponent} from './context-data-list/context-data-list.component';


@NgModule({
declarations: [
ContextDataListComponent
],
imports: [
CommonModule,
RouterModule.forChild(routes),
RouterModule.forChild([
{
path: '',
component: ContextDataListComponent,
}]),

MaterialModule,
]
})
export class TabContextDataModule {
Expand Down
10 changes: 0 additions & 10 deletions frontend/src/app/tab-context-data/tab-context-data.route.ts

This file was deleted.

20 changes: 19 additions & 1 deletion frontend/src/app/tab-others/others/others.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,29 @@ import {ReprocessGQL} from "../../../generated/graphql/sdk";
import {MatSnackBar} from "@angular/material/snack-bar";
import {ApolloError} from '@apollo/client';
import {filter, mergeMap} from 'rxjs';
import {FormsModule} from '@angular/forms';
import {MatButton} from '@angular/material/button';
import {MatDatepickerModule} from '@angular/material/datepicker';
import {MatInputModule} from '@angular/material/input';
import {provideNativeDateAdapter} from '@angular/material/core';

@Component({
standalone: true,
selector: 'app-others',
templateUrl: './others.component.html',
styleUrl: './others.component.scss'
styleUrl: './others.component.scss',
imports: [
ReprocessDialogComponent,

FormsModule,

MatButton,
MatDatepickerModule,
MatInputModule,
],
providers: [
provideNativeDateAdapter()
],
})
export class OthersComponent {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,13 @@ import {
MatDialogRef,
MatDialogTitle
} from "@angular/material/dialog";
import {MatButtonModule} from "@angular/material/button";
import {FormsModule} from "@angular/forms";
import {MatInputModule} from "@angular/material/input";
import {MatFormFieldModule} from "@angular/material/form-field";
import {MatButton} from "@angular/material/button";

@Component({
selector: 'app-reprocess-dialog',
standalone: true,
imports: [
MatFormFieldModule,
MatInputModule,
FormsModule,
MatButtonModule,
MatButton,
MatDialogTitle,
MatDialogContent,
MatDialogActions,
Expand Down
17 changes: 6 additions & 11 deletions frontend/src/app/tab-others/tab-others.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,16 @@ import {NgModule} from '@angular/core';
import {CommonModule} from '@angular/common';
import {OthersComponent} from './others/others.component';
import {RouterModule} from '@angular/router';
import {routes} from './tab-others.route';
import {MaterialModule} from "../common/material.module";
import {FormsModule} from "@angular/forms";


@NgModule({
declarations: [
OthersComponent
],
imports: [
CommonModule,
RouterModule.forChild(routes),

MaterialModule,
FormsModule
RouterModule.forChild([
{
path: '',
component: OthersComponent,
},
]),
]
})
export class TabOthersModule {
Expand Down
10 changes: 0 additions & 10 deletions frontend/src/app/tab-others/tab-others.route.ts

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
import {AfterViewInit, Component, OnInit, ViewChild} from '@angular/core';
import {GetPricingRulesGQL} from '../../../generated/graphql/sdk';
import {PricingRuleEntity} from '../../../generated/graphql/types';
import {MatSort, Sort} from '@angular/material/sort';
import {MatTableDataSource} from '@angular/material/table';
import {MatSort, MatSortModule, Sort} from '@angular/material/sort';
import {MatTable, MatTableDataSource, MatTableModule} from '@angular/material/table';
import {LiveAnnouncer} from '@angular/cdk/a11y';
import {MatSnackBar} from '@angular/material/snack-bar';

@Component({
standalone: true,
selector: 'app-pricing-rules-list',
templateUrl: './pricing-rules-list.component.html',
styleUrl: './pricing-rules-list.component.scss'
styleUrl: './pricing-rules-list.component.scss',
imports: [
MatTableModule,
MatSortModule
]
})
export class PricingRulesListComponent implements OnInit, AfterViewInit {

Expand Down
14 changes: 6 additions & 8 deletions frontend/src/app/tab-pricing-rules/tab-pricing-rules.module.ts
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
import {NgModule} from '@angular/core';
import {CommonModule} from '@angular/common';
import {PricingRulesListComponent} from './pricing-rules-list/pricing-rules-list.component';
import {MaterialModule} from '../common/material.module';
import {RouterModule} from '@angular/router';
import {routes} from './tab-pricing-rules.route';


@NgModule({
declarations: [
PricingRulesListComponent
],
imports: [
CommonModule,
RouterModule.forChild(routes),

MaterialModule,
RouterModule.forChild([
{
path: '',
component: PricingRulesListComponent,
},
]),
]
})
export class TabPricingRulesModule {
Expand Down
10 changes: 0 additions & 10 deletions frontend/src/app/tab-pricing-rules/tab-pricing-rules.route.ts

This file was deleted.

2 changes: 1 addition & 1 deletion frontend/src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<title>KafkaCostControlFrontend</title>
<title>Kafka Cost Control</title>
<base href="/">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="icon" type="image/x-icon" href="favicon.ico">
Expand Down
Loading

0 comments on commit 62b257a

Please sign in to comment.