Adding support for exporting an image as a tar archive. #330
Conversation
| } catch (IOException e) { | ||
| log.warn("IOException thrown while trying to write the image archive."); | ||
| } catch (DockerException e) { | ||
| log.warn("Docker threw an exception while trying to write the image archive: " | ||
| + e.getMessage()); | ||
| } catch (InterruptedException e) { | ||
| log.warn("InterruptedException thrown while trying to write the image archive."); | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm curious about the error handling here. It seems like if an exception was thrown by dockerClient.save() (or the file copy) then the plugin execution will continue, and probably print a BUILD SUCCESS message from Maven, but with a warning message that saving the image archive to a tarball failed.
How about failing the build in those cases? I'd assume that if someone configured the build to save the image archive to a file, they'd want the build to fail if that action failed.
There was a problem hiding this comment.
Makes perfect sense to me. I already found one case where an exception occurs: running the basic integration test, The image has scratch as a base so the tar archive is 0 bytes and an exception is thrown.
Do you think an extra integration test is needed to test the archive export
as well?
There was a problem hiding this comment.
Do you think an extra integration test is needed to test the archive export
as well?
I think that would be nice to have but not necessary
Simple draft of having the option to export the built image as a tar archive. This feature was present in the older docker-maven-plugin. Code was just borrowed from there.