Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BaseIF #1120

Closed
wants to merge 1 commit into from
Closed

Improve BaseIF #1120

wants to merge 1 commit into from

Conversation

bran1501
Copy link

@bran1501 bran1501 commented Nov 5, 2024

This will help when troubleshooting and detect when an interface is down. It should be included by default.

Type of change

Please delete options that are not relevant.

  • [ x ] Refactor/improvement

Checklist

  • My commit message is conventional
  • I have run pre-commit on all files before creating the PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • [ x ] New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

This will help when troubleshooting and detect when an interface is down. It should be included by default.
Copy link
Contributor

github-actions bot commented Nov 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ajasnosz ajasnosz self-requested a review November 6, 2024 08:51
@ajasnosz
Copy link
Collaborator

ajasnosz commented Nov 6, 2024

Hello @bran1501, I will open a new pr with the changes you propose to our develop branch.

@ajasnosz ajasnosz closed this Nov 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@ajasnosz
Copy link
Collaborator

ajasnosz commented Nov 6, 2024

#1123

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants