Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pysnmp debug mode #1069

Merged
merged 4 commits into from
Sep 17, 2024
Merged

fix: pysnmp debug mode #1069

merged 4 commits into from
Sep 17, 2024

Conversation

ikheifets-splunk
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Dependency update
  • Bug fix
  • New feature
  • Refactor/improvement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • My commit message is conventional
  • I have run pre-commit on all files before creating the PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ikheifets-splunk ikheifets-splunk force-pushed the fix/debug-mode branch 2 times, most recently from e27e2f9 to fbb79e7 Compare September 3, 2024 05:47
@ikheifets-splunk ikheifets-splunk marked this pull request as draft September 3, 2024 05:49
@ajasnosz ajasnosz self-requested a review September 3, 2024 06:30
ajasnosz
ajasnosz requested changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@ajasnosz ajasnosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run 'make render' in repository and add updated files.

splunk_connect_for_snmp/snmp/manager.py Outdated Show resolved Hide resolved
@ikheifets-splunk ikheifets-splunk force-pushed the fix/debug-mode branch 8 times, most recently from f073cd2 to 0c6cac0 Compare September 9, 2024 11:24
@ikheifets-splunk ikheifets-splunk marked this pull request as ready for review September 9, 2024 11:30
@ajasnosz ajasnosz self-requested a review September 10, 2024 11:55
ajasnosz
ajasnosz requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@ajasnosz ajasnosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run precommit to fix issues

@ikheifets-splunk ikheifets-splunk merged commit d4770e2 into develop Sep 17, 2024
9 of 12 checks passed
@ikheifets-splunk ikheifets-splunk deleted the fix/debug-mode branch September 17, 2024 08:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 1.11.1-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajasnosz ajasnosz ajasnosz approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikheifets-splunk @srv-rr-github-token @ajasnosz