Add test cases for InputStream and localhost

client/src/main/java/io/split/client/JsonLocalhostSplitChangeFetcher.java

@@ -1,6 +1,5 @@
 package io.split.client;
 
-import com.google.common.base.Charsets;
 import com.google.gson.stream.JsonReader;
 import io.split.client.dtos.SplitChange;
 import io.split.client.exceptions.InputStreamProviderException;
@@ -14,6 +13,7 @@
 
 import java.io.BufferedReader;
 import java.io.InputStreamReader;
+import java.nio.charset.StandardCharsets;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
 import java.util.Arrays;
@@ -32,15 +32,13 @@ public JsonLocalhostSplitChangeFetcher(InputStreamProvider inputStreamProvider)
     @Override
     public SplitChange fetch(long since, FetchOptions options) {
         try {
-            JsonReader jsonReader = new JsonReader(new BufferedReader(new InputStreamReader(_inputStreamProvider.get(), Charsets.UTF_8)));
+            JsonReader jsonReader = new JsonReader(new BufferedReader(new InputStreamReader(_inputStreamProvider.get(), StandardCharsets.UTF_8)));
             SplitChange splitChange = Json.fromJson(jsonReader, SplitChange.class);
             return processSplitChange(splitChange, since);
         } catch (InputStreamProviderException i) {
-            _log.warn(String.format("Problem to fetch split change using file named %s", i.getFileName()));
             throw new IllegalStateException(String.format("Problem fetching splitChanges using file named %s: %s",
                     i.getFileName(), i.getMessage()), i);
         } catch (Exception e) {
-            _log.warn(String.format("Problem to fetch split change using a file"), e);
             throw new IllegalStateException("Problem fetching splitChanges: " + e.getMessage(), e);
         }
     }

client/src/main/java/io/split/client/YamlLocalhostSplitChangeFetcher.java

@@ -5,6 +5,7 @@
 import io.split.client.dtos.Split;
 import io.split.client.dtos.SplitChange;
 import io.split.client.dtos.Status;
+import io.split.client.exceptions.InputStreamProviderException;
 import io.split.client.utils.InputStreamProvider;
 import io.split.client.utils.LocalhostConstants;
 import io.split.engine.common.FetchOptions;
@@ -22,7 +23,6 @@
 
 import static io.split.client.utils.LocalhostSanitizer.createCondition;
 
-
 public class YamlLocalhostSplitChangeFetcher implements SplitChangeFetcher {
 
     private static final Logger _log = LoggerFactory.getLogger(YamlLocalhostSplitChangeFetcher.class);
@@ -75,6 +75,9 @@ public SplitChange fetch(long since, FetchOptions options) {
             splitChange.till = since;
             splitChange.since = since;
             return splitChange;
+        } catch (InputStreamProviderException i) {
+            throw new IllegalStateException(String.format("Problem fetching splitChanges using file named %s: %s",
+                    i.getFileName(), i.getMessage()), i);
         } catch (Exception e) {
             _log.warn(String.format("Problem to fetch split change using a file"), e);
             throw new IllegalStateException("Problem fetching splitChanges: " + e.getMessage(), e);

client/src/test/java/io/split/client/JsonLocalhostSplitChangeFetcherTest.java

@@ -169,4 +169,13 @@ public void testSplitChangeSplitsDifferentScenarios() throws IOException {
         Assert.assertEquals(2323, splitChange.till);
         Assert.assertEquals(2323, splitChange.since);
     }
+
+    @Test(expected = IllegalStateException.class)
+    public void processTestForException() {
+        InputStreamProvider inputStreamProvider = new FileInputStreamProvider("src/test/resources/notExist.json");
+        JsonLocalhostSplitChangeFetcher localhostSplitChangeFetcher = new JsonLocalhostSplitChangeFetcher(inputStreamProvider);
+        FetchOptions fetchOptions = Mockito.mock(FetchOptions.class);
+
+        SplitChange splitChange = localhostSplitChangeFetcher.fetch(-1L, fetchOptions);
+    }
 }

client/src/test/java/io/split/client/SplitFactoryImplTest.java

@@ -1,7 +1,6 @@
 package io.split.client;
 
 import io.split.client.impressions.ImpressionsManager;
-import io.split.client.utils.FileInputStreamProvider;
 import io.split.client.utils.FileTypeEnum;
 import io.split.client.utils.LocalhostPair;
 import io.split.integrations.IntegrationsConfig;
@@ -21,7 +20,6 @@
 import java.lang.reflect.Field;
 import java.lang.reflect.Modifier;
 import java.net.URISyntaxException;
-import java.util.zip.InflaterInputStream;
 
 public class SplitFactoryImplTest extends TestCase {
     public static final String API_KEY ="29013ionasdasd09u";
@@ -253,4 +251,4 @@ public void testGetInputStreamProviderAndFileType() throws URISyntaxException, F
         localhostPair = splitFactory.getInputStreamProviderAndFileType(null, inputStream, FileTypeEnum.JSON);
         Assert.assertNotNull(localhostPair);
     }
-}
+}

client/src/test/java/io/split/client/YamlLocalhostSplitChangeFetcherTest.java

@@ -74,4 +74,13 @@ public void testParseSplitChange() throws IOException {
             Assert.assertEquals("control", split.defaultTreatment);
         }
     }
+
+    @Test(expected = IllegalStateException.class)
+    public void processTestForException() {
+        InputStreamProvider inputStreamProvider = new FileInputStreamProvider("src/test/resources/notExist.yaml");
+        YamlLocalhostSplitChangeFetcher localhostSplitChangeFetcher = new YamlLocalhostSplitChangeFetcher(inputStreamProvider);
+        FetchOptions fetchOptions = Mockito.mock(FetchOptions.class);
+
+        SplitChange splitChange = localhostSplitChangeFetcher.fetch(-1L, fetchOptions);
+    }
 }

client/src/test/java/io/split/client/utils/FileInputStreamProviderTest.java

@@ -0,0 +1,13 @@
+package io.split.client.utils;
+
+import io.split.client.exceptions.InputStreamProviderException;
+import org.junit.Test;
+
+public class FileInputStreamProviderTest {
+
+    @Test(expected = InputStreamProviderException.class)
+    public void processTestForException() throws InputStreamProviderException {
+        FileInputStreamProvider fileInputStreamProvider = new FileInputStreamProvider("src/test/resources/notExist.json");
+        fileInputStreamProvider.get();
+    }
+}