[SDKS-7446] Remove stop SSE from destroy when SDK is in polling mode

splitio · Sep 5, 2023 · 19ca58a · 19ca58a
1 parent d439f75
commit 19ca58a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/client/src/main/java/io/split/engine/common/SyncManagerImp.java b/client/src/main/java/io/split/engine/common/SyncManagerImp.java
@@ -160,8 +160,10 @@ public void shutdown() throws IOException {
         _shuttedDown.set(true);
         _initializationtExecutorService.shutdownNow();
         _synchronizer.stopPeriodicFetching();
-        _pushManager.stop();
-        _pushMonitorExecutorService.shutdownNow();
+        if (_streamingEnabledConfig.get()) {
+            _pushManager.stop();
+            _pushMonitorExecutorService.shutdownNow();
+        }
         _segmentSynchronizationTaskImp.close();
         _log.info("Successful shutdown of segment fetchers");
         _splitSynchronizationTask.close();

diff --git a/client/src/test/java/io/split/engine/common/SyncManagerTest.java b/client/src/test/java/io/split/engine/common/SyncManagerTest.java
@@ -64,6 +64,7 @@ public void startWithStreamingFalseShouldStartPolling() throws InterruptedExcept
         Mockito.verify(_pushManager, Mockito.times(0)).start();
 
         syncManager.shutdown();
+        Mockito.verify(_pushManager, Mockito.times(0)).stop();
         Mockito.verify(_synchronizer, Mockito.times(1)).stopPeriodicDataRecording();
     }
 
@@ -86,7 +87,7 @@ public void startWithStreamingTrueShouldStartSyncAll() throws InterruptedExcepti
     }
 
     @Test
-    public void onStreamingAvailable() throws InterruptedException, IOException {
+    public void onStreamingAvailable() throws InterruptedException {
         TelemetryStorage telemetryStorage = Mockito.mock(TelemetryStorage.class);
         LinkedBlockingQueue<PushManager.Status> messages = new LinkedBlockingQueue<>();
         SplitTasks splitTasks = SplitTasks.build(_splitSynchronizationTask, _segmentSynchronizationTaskImp,
@@ -107,7 +108,7 @@ public void onStreamingAvailable() throws InterruptedException, IOException {
     }
 
     @Test
-    public void onStreamingDisabled() throws InterruptedException, IOException {
+    public void onStreamingDisabled() throws InterruptedException {
         TelemetryStorage telemetryStorage = new InMemoryTelemetryStorage();
         LinkedBlockingQueue<PushManager.Status> messsages = new LinkedBlockingQueue<>();
         SplitTasks splitTasks = SplitTasks.build(_splitSynchronizationTask, _segmentSynchronizationTaskImp,
@@ -127,7 +128,7 @@ public void onStreamingDisabled() throws InterruptedException, IOException {
     }
 
     @Test
-    public void onStreamingShutdown() throws InterruptedException, IOException {
+    public void onStreamingShutdown() throws InterruptedException {
         TelemetryStorage telemetryStorage = new InMemoryTelemetryStorage();
         LinkedBlockingQueue<PushManager.Status> messsages = new LinkedBlockingQueue<>();
         SplitTasks splitTasks = SplitTasks.build(_splitSynchronizationTask, _segmentSynchronizationTaskImp,
@@ -229,4 +230,4 @@ public void syncAllRetryThenShouldStartPolling() throws InterruptedException, IO
         syncManager.shutdown();
         Mockito.verify(_synchronizer, Mockito.times(1)).stopPeriodicDataRecording();
     }
-}
+}