Skip to content

Commit

Permalink
chore(dependencies): Autobump korkVersion (#1275)
Browse files Browse the repository at this point in the history
* chore(dependencies): Autobump korkVersion

* refactor(dependency): replace groovy coordinates during upgrade of groovy 4.x

Replacing the groovy coordinates from `org.codehaus.groovy` to `org.apache.groovy` supported by groovy 4.x and above versions. Excluding the transitive groovy dependency from `org.jfrog.artifactory.client:artifactory-java-client-services:2.9.2`, and explictly adding the new coordinates of groovy to igor-monitor-artifactory module.

---------

Co-authored-by: root <root@b3e368603f7c>
Co-authored-by: j-sandy <[email protected]>
  • Loading branch information
3 people authored Sep 23, 2024
1 parent d1e6fd1 commit 372f869
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ subprojects {
implementation "net.logstash.logback:logstash-logback-encoder"

// TODO(rz): Why does Spock need groovy as implementation and not testImplementation to find tests?
implementation "org.codehaus.groovy:groovy"
implementation "org.apache.groovy:groovy"
testImplementation "org.springframework.boot:spring-boot-starter-test"
testImplementation "org.spockframework:spock-core"
testImplementation "org.spockframework:spock-spring"
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
fiatVersion=1.49.0
korkVersion=7.237.0
korkVersion=7.238.0
org.gradle.parallel=true
spinnakerGradleVersion=8.32.1
targetJava17=false
Expand Down
5 changes: 4 additions & 1 deletion igor-monitor-artifactory/igor-monitor-artifactory.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ dependencies {
implementation "org.springframework.boot:spring-boot-starter-actuator"
implementation "org.springframework.boot:spring-boot-starter-web"

implementation "org.jfrog.artifactory.client:artifactory-java-client-services:2.9.2"
implementation("org.jfrog.artifactory.client:artifactory-java-client-services:2.9.2") {
exclude group: "org.codehaus.groovy", module: "*"
}
implementation "org.apache.groovy:groovy"

// TODO(rz): Get rid of this dependency!
implementation "io.spinnaker.kork:kork-jedis"
Expand Down
6 changes: 3 additions & 3 deletions igor-web/igor-web.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ dependencies {
testImplementation "org.hamcrest:hamcrest-core"
testRuntimeOnly "cglib:cglib-nodep"
testRuntimeOnly "org.objenesis:objenesis"
implementation "org.codehaus.groovy:groovy"
implementation "org.apache.groovy:groovy"

implementation "com.fasterxml.jackson.core:jackson-annotations"
implementation "com.fasterxml.jackson.core:jackson-core"
Expand Down Expand Up @@ -81,8 +81,8 @@ dependencies {

testImplementation "com.squareup.okhttp:mockwebserver"
testImplementation "io.spinnaker.kork:kork-jedis-test"
testImplementation "org.codehaus.groovy:groovy-datetime"
testImplementation "org.codehaus.groovy:groovy-json"
testImplementation "org.apache.groovy:groovy-datetime"
testImplementation "org.apache.groovy:groovy-json"
testImplementation "org.junit.jupiter:junit-jupiter-api"
testImplementation "org.assertj:assertj-core"

Expand Down

0 comments on commit 372f869

Please sign in to comment.