Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s quickstart: Fix namespace in workload registration apply #311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jsnctl
Copy link

@jsnctl jsnctl commented May 6, 2024

Description of the change

Amends the namespace used when registering the workload in the Kubernetes Quickstart example. This is erroneously set to default in the example kubectl apply, it should be set to spire

Which issue this PR fixes

Not in this repo, but this was raised in spire-tutorials last September: spiffe/spire-tutorials#123

Copy link

netlify bot commented May 6, 2024

Deploy Preview for spiffe ready!

Name Link
🔨 Latest commit daa799b
🔍 Latest deploy log https://app.netlify.com/sites/spiffe/deploys/663f5e41c85a59000806efa3
😎 Deploy Preview https://deploy-preview-311--spiffe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akaloti
Copy link

akaloti commented May 14, 2024

Doesn't the tutorial command for the workload container put it in default namespace? (the kubectl apply -f client-deployment.yaml)
If changing the namespace referenced in the registration entry, I think you'd need to change the command too.

Copy link
Contributor

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

assuming you have tested and the new approach works as expected.

thanks for your contribution 🙏 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants