Skip to content

Commit

Permalink
Update to go 1.22.3, fix Dockerfile warnings (#174)
Browse files Browse the repository at this point in the history
* Update to go 1.22.3, fix Dockerfile warnings

Signed-off-by: Faisal Memon <[email protected]>

* Remove default version from dockerfile

Signed-off-by: Faisal Memon <[email protected]>

---------

Signed-off-by: Faisal Memon <[email protected]>
  • Loading branch information
faisal-memon committed Sep 11, 2024
1 parent f365fcb commit 089a13d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/tests/it/spiffe-helper/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.1-alpine AS spiffe-helper
FROM golang:1.22.3-alpine AS spiffe-helper
COPY ./ /service/
WORKDIR /service
RUN go build -tags netgo -a -v -o /service/spiffe-helper ./cmd/spiffe-helper
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Build the spiffe-helper binary
ARG go_version
FROM --platform=$BUILDPLATFORM golang:${go_version}-alpine as base
FROM --platform=$BUILDPLATFORM golang:${go_version}-alpine AS base
WORKDIR /workspace

# Cache deps before building and copying source so that we don't need to re-download as much
Expand All @@ -18,7 +18,7 @@ COPY pkg/ pkg/
# crane digest tonistiigi/xx:1.3.0
FROM --platform=${BUILDPLATFORM} tonistiigi/xx@sha256:904fe94f236d36d65aeb5a2462f88f2c537b8360475f6342e7599194f291fb7e AS xx

FROM --platform=${BUILDPLATFORM} base as builder
FROM --platform=${BUILDPLATFORM} base AS builder
ARG TARGETPLATFORM
ARG TARGETARCH

Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/spiffe/spiffe-helper

go 1.22.1
go 1.22.3

require (
github.com/hashicorp/hcl v1.0.0
Expand Down

0 comments on commit 089a13d

Please sign in to comment.