Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: make gap limit for change configurable #8726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Filiprogrammer
Copy link

Add the ability to configure the gap limit for change addresses while
retaining that value in the wallet database.

Add the ability to configure the gap limit for change addresses while
retaining that value in the wallet database.
@SomberNight
Copy link
Member

Hi. What is your use case for this?

note: related issue at #6440

@Filiprogrammer
Copy link
Author

  • Users may need to restore an existing wallet from a seed that includes transactions on change addresses beyond the current hardcoded gap limit. With the current setup, users have to manually change the gap limit for change addresses every time they open the wallet in Electrum. Introducing a configurable option that is saved in the wallet database alleviates this manual task, providing a more user-friendly experience and reducing the risk of oversight.
  • Another point is consistency. Currently, receiving addresses allow for a configurable gap limit, while change addresses are limited by a hardcoded value.
  • The ability to change the gap limit for change addresses via the CLI electrum changegaplimit <newlimit> --iknowwhatimdoing --change offers power users a convenient method for adjusting their wallet settings. And again, since it is already possible to change the gap limit for receiving addresses via the CLI, it makes sense to be consistent and have the same ability for change addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants