fixed some clang compiler warnings

speckdavid · May 2, 2024 · a15e594 · a15e594
1 parent a3f5f87
commit a15e594
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 10 deletions.
diff --git a/src/search/ext/boost_dependencies/boost/smart_ptr/shared_ptr.hpp b/src/search/ext/boost_dependencies/boost/smart_ptr/shared_ptr.hpp
@@ -32,6 +32,10 @@
 #include <boost/smart_ptr/detail/sp_disable_deprecated.hpp>
 #include <boost/smart_ptr/detail/sp_noexcept.hpp>
 
+#ifndef BOOST_NO_AUTO_PTR
+# include <memory>          // for std::auto_ptr
+#endif
+
 #if !defined(BOOST_SP_NO_ATOMIC_ACCESS)
 #include <boost/smart_ptr/detail/spinlock_pool.hpp>
 #endif

diff --git a/src/search/symbolic/search_engines/symbolic_search.h b/src/search/symbolic/search_engines/symbolic_search.h
@@ -78,7 +78,7 @@ class SymbolicSearch : public SearchEngine {
 
     virtual void new_solution(const SymSolutionCut &sol);
 
-    virtual void print_statistics() const {}
+    virtual void print_statistics() const override {}
 
     virtual void save_plan_if_necessary() override;
 

diff --git a/src/search/symbolic/searches/uniform_cost_search.h b/src/search/symbolic/searches/uniform_cost_search.h
@@ -78,7 +78,7 @@ class UniformCostSearch : public SymSearch {
     UniformCostSearch &operator=(UniformCostSearch &&) = default;
     virtual ~UniformCostSearch() = default;
 
-    virtual bool finished() const {
+    virtual bool finished() const override {
         return open_list.empty() && frontier.empty();
     }
 
@@ -94,11 +94,10 @@ class UniformCostSearch : public SymSearch {
         return fw ? "FW" : "BW";
     }
 
-    virtual void stepImage(int maxTime, int maxNodes);
+    virtual void stepImage(int maxTime, int maxNodes) override;
 
-    bool
-    init(std::shared_ptr<SymStateSpaceManager> manager, bool fw,
-         UniformCostSearch *opposite_search); // Init forward or backward search
+    bool init(std::shared_ptr<SymStateSpaceManager> manager, bool fw,
+              UniformCostSearch *opposite_search); // Init forward or backward search
 
     virtual int getF() const override {
         return open_list.minNextG(frontier, mgr->get_min_transition_cost());

diff --git a/src/search/symbolic/sym_estimate.h b/src/search/symbolic/sym_estimate.h
@@ -7,7 +7,7 @@
 #include <utility>
 
 namespace symbolic {
-class SymParameters;
+struct SymParameters;
 
 class Estimation {
 protected:

diff --git a/src/search/tasks/effect_aggregated_task.h b/src/search/tasks/effect_aggregated_task.h
@@ -29,7 +29,7 @@ class EffectAggregatedTask : public tasks::DelegatingTask {
     virtual FactPair get_operator_effect_condition(int op_index, int eff_index, int cond_index, bool is_axiom) const override;
     virtual FactPair get_operator_effect(int op_index, int eff_index, bool is_axiom) const override;
 
-    virtual int convert_operator_index_to_parent(int index) const;
+    virtual int convert_operator_index_to_parent(int index) const override;
 
     const std::vector<int> &get_operators_beloning_to_parent(int index) const;
 };

diff --git a/src/search/tasks/sdac_task.h b/src/search/tasks/sdac_task.h
@@ -23,7 +23,7 @@ class SdacTask : public tasks::DelegatingTask {
              symbolic::SymVariables *sym_vars);
     ~SdacTask() = default;
 
-    virtual int get_operator_cost(int index, bool is_axiom) const;
+    virtual int get_operator_cost(int index, bool is_axiom) const override;
     virtual std::string get_operator_name(int index, bool is_axiom) const override;
     virtual int get_num_operators() const override;
     virtual int get_num_operator_preconditions(int index, bool is_axiom) const override;
@@ -37,7 +37,7 @@ class SdacTask : public tasks::DelegatingTask {
     virtual FactPair get_operator_effect(
         int op_index, int eff_index, bool is_axiom) const override;
 
-    virtual int convert_operator_index_to_parent(int index) const;
+    virtual int convert_operator_index_to_parent(int index) const override;
 
 
     BDD get_operator_cost_condition(int index, bool is_axiom) const;