Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/get delete body #1712

Merged
merged 11 commits into from
Oct 23, 2023
Merged

Conversation

Ruwann
Copy link
Member

@Ruwann Ruwann commented Jun 12, 2023

Fixes #1689

Changes proposed in this pull request:

  • Pass through request body in case of GET and DELETE requests

tests/api/test_parameters.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 12, 2023

Coverage Status

coverage: 94.428% (+0.006%) from 94.422% when pulling aea2759 on Ruwann:feature/get-delete-body into 655ea43 on spec-first:main.

@Ruwann Ruwann marked this pull request as ready for review June 14, 2023 11:22
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ruwann!

Should we add a specific test for this behavior? Now it's only implicit in existing tests and we don't test for the GET and similar methods.

Also, I guess this can be a breaking change for users that handled the passed in empty body, so we might want to add this to the smaller breaking changes in the changelog.

connexion/decorators/parameter.py Outdated Show resolved Hide resolved
@RobbeSneyders
Copy link
Member

Can you have a look at my comments above @Ruwann? 🙂

@Ruwann
Copy link
Member Author

Ruwann commented Oct 21, 2023

Thanks for the comments, I think I got them all :)

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ruwan!

I had another look at the HTTP spec, and seems like there is one method which MUST NOT include a request body, which is the TRACE method. Maybe we should still exclude it.

docs/v3.rst Outdated Show resolved Hide resolved
@Ruwann
Copy link
Member Author

Ruwann commented Oct 23, 2023

Thanks, I indeed didn't spot that one - nice catch. Had another look and I also think that's the only one, I'll update the PR accordingly!

@RobbeSneyders RobbeSneyders merged commit 79fd9ed into spec-first:main Oct 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Body in GET/DELETE requests in 3.x
3 participants