-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/get delete body #1712
Feature/get delete body #1712
Conversation
c2d0d23
to
074f3b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ruwann!
Should we add a specific test for this behavior? Now it's only implicit in existing tests and we don't test for the GET and similar methods.
Also, I guess this can be a breaking change for users that handled the passed in empty body, so we might want to add this to the smaller breaking changes in the changelog.
Can you have a look at my comments above @Ruwann? 🙂 |
This reverts commit 074f3b0.
dbca336
to
13022ea
Compare
Thanks for the comments, I think I got them all :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ruwan!
I had another look at the HTTP spec, and seems like there is one method which MUST NOT include a request body, which is the TRACE method. Maybe we should still exclude it.
Thanks, I indeed didn't spot that one - nice catch. Had another look and I also think that's the only one, I'll update the PR accordingly! |
Co-authored-by: Robbe Sneyders <[email protected]>
Fixes #1689
Changes proposed in this pull request:
GET
andDELETE
requests