Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples links in security doc page #1677

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Fix examples links in security doc page #1677

merged 1 commit into from
Mar 24, 2023

Conversation

opheron
Copy link
Contributor

@opheron opheron commented Mar 20, 2023

Contributes to #1531

The links in security doc were pointing at an old repo and folders.
These links could be changed down the road to use relative paths since they point to the repo internally.

@opheron opheron marked this pull request as ready for review March 20, 2023 17:51
Ruwann
Ruwann approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@opheron opheron marked this pull request as draft March 23, 2023 17:26
@opheron
Copy link
Contributor Author

opheron commented Mar 23, 2023

Thanks for the PR!

You're welcome, let me know if you have any other specific issues that I can get my hands a little dirtier!

I just changed this back to draft, could you hold off on merging for a bit? I accidentally signed commits with the wrong account/user info, I just need to amend those and it'll be good go.

@opheron opheron force-pushed the feat/update-security-doc-examples branch from c765612 to c7b9f7b Compare March 23, 2023 17:57
@coveralls
Copy link

coveralls commented Mar 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4504107189

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.398%
Totals Coverage Status
Change from base Build 4503851743: 0.0%
Covered Lines: 3296
Relevant Lines: 3529
💛 - Coveralls

@opheron opheron force-pushed the feat/update-security-doc-examples branch from c7b9f7b to d69a9d7 Compare March 23, 2023 18:25
@opheron
Fix examples links in security doc page
b5b4171 
Links in security doc were pointing at old repo and folders
@opheron opheron force-pushed the feat/update-security-doc-examples branch from d69a9d7 to b5b4171 Compare March 23, 2023 18:41
@opheron opheron marked this pull request as ready for review March 23, 2023 18:46
@opheron
Copy link
Contributor Author

opheron commented Mar 23, 2023

@Ruwann Fixed the commit signing and rebased to include the recent changes to main, so no code changes this time. Ready for merge! :)

@Ruwann
Copy link
Member

Ruwann commented Mar 24, 2023 •
edited
Loading

Great, thanks, @opheron !

You're welcome, let me know if you have any other specific issues that I can get my hands a little dirtier!

There are some open issues marked as good first issue but these might not be all relevant anymore with connexion 3.0.

However, if you have any specific areas you're interested or experienced in, we can definitely look at some other open issues. For example, connexion currently does not support the OIDC security scheme or is lacking OpenAPI 3.1 support.

@Ruwann Ruwann merged commit 8cebebc into spec-first:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruwann Ruwann Ruwann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opheron @coveralls @Ruwann