wxWindows: Collapse to a single <notes> element #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XSD schema is currently buggy on this point, but the plural element name (<notes> vs. <note>) and maxOccurs in the XSD entry: <element name="notes" type="tns:formattedFixedTextType" minOccurs="0" maxOccurs="1"/> suggest that we expect only a single note entry.
wking
added a commit
to wking/license-list-XML
that referenced
this pull request
Jan 11, 2018
The XSD suggests (buggily) that we only want a single <notes> element (more details on this in 5010132, wxWindows: Collapse to a single <notes> element, 2017-12-27, spdx#577). And the information contained in the <notes> section I'm removing is redundant, because the titleText contains the release date. I don't see a need to include that release date as unstrucutured information in two places, and the license title is clearly the more important location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XSD schema is currently buggy on this point, but the plural element name (
<notes>vs.<note>) andmaxOccursin the XSD entry:suggest that we expect only a single note entry.
Spun off from #566.