-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed RedundantArray
's handling of "reshaping" Memlets
#1603
Fixed RedundantArray
's handling of "reshaping" Memlets
#1603
Commits on Jun 19, 2024
-
Added a test for the
RedundantArray
fix.I also verified that without the fix the test will fail.
Configuration menu - View commit details
-
Copy full SHA for 7ea9a62 - Browse repository at this point
Copy the full SHA 7ea9a62View commit details -
Configuration menu - View commit details
-
Copy full SHA for caa06af - Browse repository at this point
Copy the full SHA caa06afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f11fea - Browse repository at this point
Copy the full SHA 3f11feaView commit details -
This _should_ fix the issue that is reported in spcl#1595.
It essentially creates a special case for it and applies then the correct way. This is not very good but it works and I have no better solution.
Configuration menu - View commit details
-
Copy full SHA for 742568d - Browse repository at this point
Copy the full SHA 742568dView commit details -
Revert "This _should_ fix the issue that is reported in spcl#1595."
This is for investigate why the CI fails. After this commit all tests except the one I had added should pass. And NOAA which should also fail. This reverts commit 742568d.
Configuration menu - View commit details
-
Copy full SHA for 8ec3c58 - Browse repository at this point
Copy the full SHA 8ec3c58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2650b70 - Browse repository at this point
Copy the full SHA 2650b70View commit details -
Reapply "This _should_ fix the issue that is reported in spcl#1595."
This reverts commit 8ec3c58.
Configuration menu - View commit details
-
Copy full SHA for 5300a1f - Browse repository at this point
Copy the full SHA 5300a1fView commit details
Commits on Jul 3, 2024
-
As suggested by Alexandros (@alexnick83) the transformation no longer…
… handles the reshaping case but simply ignore it. I put everything inside a helper function.
Configuration menu - View commit details
-
Copy full SHA for f649fd6 - Browse repository at this point
Copy the full SHA f649fd6View commit details -
In the previous versions I tried to simply ignore the reshaping Memlet case, however, this break other tests. In this version reshaping Memlets are not turned into a view, i.e. the source array is not removed but turned into a view. This fixed the other tests again. It is not the best solution but it works.
Configuration menu - View commit details
-
Copy full SHA for b325c22 - Browse repository at this point
Copy the full SHA b325c22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 476d760 - Browse repository at this point
Copy the full SHA 476d760View commit details
Commits on Jul 4, 2024
-
Updated the definition of a reshaping Memlet.
A reshaping memlet must change the shape of a datacontainer. However, in the old version also the total size was considered. Which is not fully correct, as the total size is more related to the memory layout and not to the "computational domain".
Configuration menu - View commit details
-
Copy full SHA for cfbca93 - Browse repository at this point
Copy the full SHA cfbca93View commit details