Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RedundantArray's handling of "reshaping" Memlets #1603

Merged
merged 11 commits into from
Jul 4, 2024

Commits on Jun 19, 2024

  1. Added a test for the RedundantArray fix.

    I also verified that without the fix the test will fail.
    philip-paul-mueller committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    7ea9a62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    caa06af View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3f11fea View commit details
    Browse the repository at this point in the history
  4. This _should_ fix the issue that is reported in spcl#1595.

    It essentially creates a special case for it and applies then the correct way.
    This is not very good but it works and I have no better solution.
    philip-paul-mueller committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    742568d View commit details
    Browse the repository at this point in the history
  5. Revert "This _should_ fix the issue that is reported in spcl#1595."

    This is for investigate why the CI fails.
    After this commit all tests except the one I had added should pass.
    And NOAA which should also fail.
    
    This reverts commit 742568d.
    philip-paul-mueller committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    8ec3c58 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2650b70 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5300a1f View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. As suggested by Alexandros (@alexnick83) the transformation no longer…

    … handles the reshaping case but simply ignore it.
    
    I put everything inside a helper function.
    philip-paul-mueller committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f649fd6 View commit details
    Browse the repository at this point in the history
  2. Updated the transformations.

    In the previous versions I tried to simply ignore the reshaping Memlet case, however, this break other tests.
    In this version reshaping Memlets are not turned into a view, i.e. the source array is not removed but turned into a view.
    This fixed the other tests again.
    
    It is not the best solution but it works.
    philip-paul-mueller committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b325c22 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    476d760 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Updated the definition of a reshaping Memlet.

    A reshaping memlet must change the shape of a datacontainer.
    However, in the old version also the total size was considered.
    Which is not fully correct, as the total size is more related to the memory layout and not to the "computational domain".
    philip-paul-mueller committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    cfbca93 View commit details
    Browse the repository at this point in the history