Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Energy widgets #219
Energy widgets #219
Changes from all commits
541e778
e70bacc
3d9720c
8b24315
b029a33
7346948
a9ab845
31dec36
94388b5
86e1576
a0b135f
df4ba3a
7145a93
f9bce08
6e04e22
945110f
e040cde
f405e95
4ed0f9d
40d35ae
894e63a
156efb6
ce8f5cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For line 56 and 57, the max and min energy for Si (111) is from 4 to 40 keV, for ML it is 5~22 depending on the gap? Should we distinguish ML from (111) here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will re-write this to get the min/max values from the monochromator.
Eventually, we will also need a check when setting the energy to ensure it's within range for the mono/ID/2° mono.
For now, we'll use 5 -- 38keV for 25-ID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to derive the range of valid energies from the limits on the setpoint of the mono energy and ID energy. This way, we can set those values properly in EPICS and everything just kind of works.
Right now the range is 10 eV to 35000 eV, which is wrong, but it's wrong because the limits are not set properly. The current limits are: