-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planwindows #218
Planwindows #218
Conversation
…ore calculate time
) | ||
|
||
# get snake axes, if all unchecked, set it None | ||
snake_axes = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked that this actually works? According to the documentation:
The elements of the list are motors that are listed in args.
I read that to mean that the arguments should be the motors themselves, not their indices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be discussed
…f start and stop values
…cks whether md includes valid items such as non-empty strings
…emoved from the metadata in test_xafs_scan
…) to prevent errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. The only things I noticed are where the is_valid_value()
function doesn't do what it says on the tin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Once the CI passes, we can merge.
Add grid_scan and included enhanced utilities #207 #210