Return slugs in find methods (#443)

* Return slugs in find methods I assume if a "name" is in slug format, that the slug will be the same as the name?! Assumption aside, I don't see any side effects for methods like `findOrCreateFromString` which call these changed functions. * Revert changes to test tests :S * Allow find strings methods to search via slug as well Switch to anonymous migration and void return type for up method (#440) Method for reversing migrations (#442) * Method for reversing migrations * Add missing return type declaration wip Update README.md fix tests Fix styling Update CHANGELOG Return slugs in find methods I assume if a "name" is in slug format, that the slug will be the same as the name?! Assumption aside, I don't see any side effects for methods like `findOrCreateFromString` which call these changed functions. Revert changes to test tests :S allow find from string methods to search slug field Co-authored-by: ziming <[email protected]>
spatie · Jan 25, 2023 · 490a882 · 490a882
1 parent fe7d796
commit 490a882
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/Tag.php b/src/Tag.php
@@ -64,14 +64,17 @@ public static function getWithType(string $type): DbCollection
     {
         return static::withType($type)->get();
     }
-
+    
     public static function findFromString(string $name, string $type = null, string $locale = null)
     {
         $locale = $locale ?? static::getLocale();
 
         return static::query()
-            ->where("name->{$locale}", $name)
             ->where('type', $type)
+            ->where(function($query) use ($name, $locale) {
+                $query->where("name->{$locale}", $name)
+                    ->orWhere("slug->{$locale}", $name);
+            })
             ->first();
     }
 
@@ -81,6 +84,7 @@ public static function findFromStringOfAnyType(string $name, string $locale = nu
 
         return static::query()
             ->where("name->{$locale}", $name)
+            ->orWhere("slug->{$locale}", $name)
             ->get();
     }