Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ feat (node): Node and Sass are supported versions #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cromwellryan
Copy link

Node was 10 which went out of support in May. Sass replaces node-sass
which is recommendd by webpack's sass-laoder and actually builds on
modern version of Python and Node.

The following steps outline the added experience by the pull request:

  • Ensure CircleCI passes
  • Pull the repo, rm -rf node_modules, ensure npm i passes
  • Switch to node 12 (or something), and try to npm start - should receive an error about 14+
  • Ensure the site looks right when running the app

Node was 10 which went out of support in May. Sass replaces node-sass
which is recommendd by webpack's sass-laoder and actually builds on
modern version of Python and Node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant