Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: NumPy 2.0 compatibility, other fixes #363

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 8, 2023

Description

This pull request is to fix #362 and any resulting modernization that has to happen.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

Got rid of oldest-supported-numpy in build.
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
synphot/observation.py 100.00%
synphot/spectrum.py 100.00%

📢 Thoughts on this report? Let us know!.

@pllim

This comment was marked as resolved.

@pllim
Copy link
Contributor Author

pllim commented Sep 8, 2023

Phew... Not too bad.

@pllim pllim marked this pull request as ready for review September 8, 2023 19:07
@pllim
Copy link
Contributor Author

pllim commented Sep 8, 2023

I cannot fix stsynphot easily without merging this, so just gonna merge...

@pllim pllim merged commit 9623ba0 into spacetelescope:master Sep 8, 2023
21 checks passed
@pllim pllim deleted the npy2-and-friends branch September 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MNT: NumPy 2.0 compatibility
1 participant