Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate get_fileext #363

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

deprecate get_fileext #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4115b1f
deprecate get_fileext
braingram Nov 15, 2024
570e69e
add changelog
braingram Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/363.removal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Deprecate DataModel.get_fileext.
4 changes: 4 additions & 0 deletions src/stdatamodels/model_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,6 +996,10 @@ def schema(self):
return self._schema

def get_fileext(self):
warnings.warn(
"get_fileext always returns 'fits' and will be removed in an upcoming release",
DeprecationWarning
)
return 'fits'

@property
Expand Down
6 changes: 6 additions & 0 deletions tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,3 +326,9 @@ def find_gen_by_id(object_id):
# many models which would indicate they are difficult to garbage
# collect.
assert len(mids) < 2


def test_get_fileext_deprecation():
m = DataModel()
with pytest.warns(DeprecationWarning):
assert m.get_fileext() == 'fits'