-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fits keywords to NRMModel schema #361
base: main
Are you sure you want to change the base?
Conversation
c31b1d3
to
73785bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage 67.51% 67.51%
=======================================
Files 114 114
Lines 5913 5913
=======================================
Hits 3992 3992
Misses 1921 1921 ☔ View full report in Codecov by Sentry. |
I think this looks good! To make sure I understand, these will not be accessed via the |
Exactly! Feel free to give it a try with the current NRM reference file (and this branch) if you're curious. |
Thanks! I was able to try it with your branch and it looks good! I realized that there may be two additional keywords whose values are currently hardcoded but that we could read in from this model instead, but I need to confirm if they are actually the same as values we already have in the FITS header, and if so, what we should call the attributes. I should have an answer on that tomorrow.
|
I'll mark this as draft until we hear back about the extra keywords. |
I spoke to my AMI team members and chased down the source of these numbers (or what we should be using) and we'd like to add these two:
Thanks for your patience!! |
dd53bef
to
c6133f4
Compare
Closes #359
The NRM reference files contain FITS keywords useful to CAL.
https://jwst-crds.stsci.edu/browse/jwst_niriss_nrm_0001.fits
This PR adds those keywords to the schema so they are accessible via the datamodel interface:
model.flat_to_flat
model.x_a1
etc...Regression tests running at https://github.com/spacetelescope/RegressionTests/actions/runs/11802888443
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)jwst
regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>"
)news fragment change types...
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.misc.rst
: infrastructure or miscellaneous change