deprecate schema_editor #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
+ Coverage 66.55% 67.51% +0.96%
==========================================
Files 102 114 +12
Lines 5456 5913 +457
==========================================
+ Hits 3631 3992 +361
- Misses 1825 1921 +96 ☔ View full report in Codecov by Sentry. |
braingram
force-pushed
the
deprecate_schema_editor
branch
2 times, most recently
from
973b130
to
91cd3fa
Compare
10 tasks
braingram
force-pushed
the
deprecate_schema_editor
branch
from
91cd3fa
to
0d9f0b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a UserWarning if the schema_editor submodule is imported.
spacetelescope/jwst#8909 removed its use in jwst
before merging this PR I'll make an issue to track the removal of schema_editor. I'm not sure if this qualifies as "public API" (since it's undocumented and untested in this package) so I'm ok removing it in the next minor version (so it's not picked up by current jwst releases).
Regression tests running at: https://github.com/spacetelescope/RegressionTests/actions/runs/11632063641
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)jwstregression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change