Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmark] use mamba in environment construction #185

Closed
wants to merge 1 commit into from

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Aug 3, 2023

the conda environment construction in asv currently fails on tangra3 due to the current setup; however, switching the environment_type to mamba does work.

mamba is a rewrite of conda that is both significantly faster in the environment resolution step and has parity of commands with conda. Since the regular benchmarking on tangra3 creates an environment, it makes sense to use mamba going forward.

asv currently supports environment_type = mamba in its main branch code, and AFAIK this will be included in the next release. For now, the tangra3 benchmarks use pip install git+https://github.com/airspeed-velocity/asv.git

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2256c48) 75.36% compared to head (6b4ebb8) 75.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   75.36%   75.36%           
=======================================
  Files          33       33           
  Lines        6039     6039           
=======================================
  Hits         4551     4551           
  Misses       1488     1488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett changed the title use mamba in environment construction [benchmark] use mamba in environment construction Aug 3, 2023
@kmacdonald-stsci
Copy link
Collaborator

What is the advantage of Mamba over Conda? That's not explained in this PR.

@zacharyburnett
Copy link
Collaborator Author

What is the advantage of Mamba over Conda? That's not explained in this PR.

Whoops, sorry! updated the description

@nden
Copy link
Collaborator

nden commented Aug 29, 2023

Now that benchmarks are in bench, should this be closed?

@zacharyburnett zacharyburnett deleted the fix/mamba branch August 29, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants