Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pie wedge segmented aperture #604

Merged

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Dec 20, 2023

  • Adds a WedgeSegmentedCircularAperture class, for defining pie-wedge or keystone-shaped apertures; some of the aperture geometries under consideration for HWO need this kind of aperture.
  • Also, minor enhancement to radial_profile function adding a custom_function parameter, which lets you compute an arbitrary function evaluated in over each radial bin, for instance the min or max at a given radius. This generalizes the prior approach used for computing std dev or median absolute deviation in each bin. \
  • Tests for both the above are included.

Example:

Unknown-26

@mperrin mperrin added the enhancement New feature or request label Dec 20, 2023
@mperrin mperrin self-assigned this Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fa90e1) 74.13% compared to head (21f916a) 74.30%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #604      +/-   ##
===========================================
+ Coverage    74.13%   74.30%   +0.16%     
===========================================
  Files           18       18              
  Lines         6558     6600      +42     
===========================================
+ Hits          4862     4904      +42     
  Misses        1696     1696              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, working as intended, in particular, the test_WedgeSegmentedCircularAperture function
image

@BradleySappington BradleySappington merged commit 9b9d981 into spacetelescope:develop Jan 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants