Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin sphinx version #594

Merged

Conversation

BradleySappington
Copy link
Collaborator

@BradleySappington BradleySappington commented Oct 13, 2023

dont need to say less than max version for sphinx

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

see 9 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@BradleySappington BradleySappington self-assigned this Oct 13, 2023
@BradleySappington
Copy link
Collaborator Author

@obi-wan76 - Ready for review

Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@BradleySappington BradleySappington merged commit 5c89c3c into spacetelescope:develop Nov 8, 2023
8 checks passed
@BradleySappington BradleySappington deleted the sphinx_version branch November 8, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants