Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.py - add Median Absolute Deviation option to radial_profile #591

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

saikrishanthpm
Copy link
Contributor

Added ability to compute median absolute deviation (MAD) to the radial profile function. MAD is a better estimator than standard deviation for smaller datasets, being more robust to outliers.

Added ability to compute median absolute deviation (MAD) to the radial profile function. MAD is a better estimator than standard deviation for smaller datasets, being more robust to outliers.
@mperrin mperrin changed the title Update utils.py Update utils.py - add Median Absolute Deviation option to radial_profile Dec 11, 2023
Copy link
Collaborator

@mperrin mperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saikrishanthpm Thank you for this PR adding the median absolute deviation option. I've tested it and it looks good to me.

For completeness I added to this PR some unit test code that exercises this option and the stddev option (this test could be made a lot better -- for now it just checks that the code runs without error and the output array has the correct number of bins, without any check of the correctness of the output values. But, better than no test at all!). I'll verify the CI tests all run with that addition and then merge.

Thanks again.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e2d84d) 74.46% compared to head (7b1babb) 74.13%.
Report is 29 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #591      +/-   ##
===========================================
- Coverage    74.46%   74.13%   -0.34%     
===========================================
  Files           18       18              
  Lines         6549     6558       +9     
===========================================
- Hits          4877     4862      -15     
- Misses        1672     1696      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mperrin mperrin merged commit 9fa90e1 into spacetelescope:develop Dec 11, 2023
7 of 8 checks passed
@saikrishanthpm saikrishanthpm deleted the patch-1 branch December 11, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants