-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug in AmiAverageStep spec that prevents step creation #8677
Conversation
Given that this step couldn't be created I am inclined to skip regression tests as the step is effectively untested. |
A question related to this PR: do you know if NIRISS expects this step to be used? It is not part of the reworked AMI pipeline, right? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8677 +/- ##
==========================================
+ Coverage 60.36% 60.47% +0.10%
==========================================
Files 372 369 -3
Lines 38320 38408 +88
==========================================
+ Hits 23132 23226 +94
+ Misses 15188 15182 -6 ☔ View full report in Codecov by Sentry. |
Thanks for giving it a look. I don't believe they expect this to be used (currently) based on the comment in the description for #7862:
Perhaps @rcooper295 knows more. I only noticed the issue fixed in this PR because I tried to create a basic instance of every step (to try and wrangle the suffix calculations since that appears to be one limitation for removing the deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending rebase, LGTM
4b4dc4c
to
cf91724
Compare
The step spec for
AmiAverageStep
contains an invalid entry:jwst/jwst/ami/ami_average_step.py
Lines 14 to 16 in 7d97170
which leads to an error when attempting to construct the step:
This PR fixes the spec and adds a very basic unit test to verify the step can be instantiated.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR