Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update metadata for 1.14.0 #8380

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Mar 21, 2024

waiting for the following before unit and regression testing can start:

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.31%. Comparing base (2fb073e) to head (05e03cd).
Report is 10 commits behind head on master.

❗ Current head 05e03cd differs from pull request most recent head f9f6117. Consider uploading reports for the commit f9f6117 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8380      +/-   ##
==========================================
+ Coverage   75.31%   77.31%   +2.00%     
==========================================
  Files         474      451      -23     
  Lines       38965    35059    -3906     
==========================================
- Hits        29345    27106    -2239     
+ Misses       9620     7953    -1667     
Flag Coverage Δ *Carryforward flag
nightly 77.31% <ø> (-0.03%) ⬇️ Carriedforward from 2fb073e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett added this to the Build 10.2 milestone Mar 21, 2024
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@hbushouse
Copy link
Collaborator

hbushouse commented Mar 21, 2024

Need to add #8303 as an item we need/want in the first release.

@zacharyburnett
Copy link
Collaborator Author

one failed test:
https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST/detail/JWST/2829/pipeline/202#step-203-log-201

E           FileNotFoundError: [Errno 2] No such file or directory: '/data1/jenkins/workspace/RT/JWST/clone/test_outputs/popen-gw3/test_image3_closedfile0/jw00617-o082_t001_nircam_clear-f090w-sub320_i2d.fits'

@zacharyburnett zacharyburnett marked this pull request as ready for review March 25, 2024 19:12
@zacharyburnett zacharyburnett requested a review from a team as a code owner March 25, 2024 19:12
CITATION.cff Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
@hbushouse
Copy link
Collaborator

one failed test: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST/detail/JWST/2829/pipeline/202#step-203-log-201

E           FileNotFoundError: [Errno 2] No such file or directory: '/data1/jenkins/workspace/RT/JWST/clone/test_outputs/popen-gw3/test_image3_closedfile0/jw00617-o082_t001_nircam_clear-f090w-sub320_i2d.fits'

Not an issue. That's one of the 3 or 4 tests that frequently fail for no obvious reason.

README.md Outdated Show resolved Hide resolved
@zacharyburnett zacharyburnett enabled auto-merge (squash) March 25, 2024 19:16
@zacharyburnett zacharyburnett merged commit a8476e8 into spacetelescope:master Mar 25, 2024
29 of 33 checks passed
@zacharyburnett zacharyburnett deleted the release_metadata branch March 25, 2024 19:24
@hbushouse
Copy link
Collaborator

Didn't we want to include #7862 yet, before tagging master? Or is this just meta data update and actual 1.14.0 tag will come later?

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Mar 25, 2024

Didn't we want to include #7862 yet, before tagging master? Or is this just meta data update and actual 1.14.0 tag will come later?

I made a 1.14.0 tag without it, but deleted it just now after @braingram's comment (there was no PyPI release so no harm done). I'll re-tag including #7862 when it's merged

@braingram
Copy link
Collaborator

I re-based #7862 it's running the CI now (it looks like that's a requirement for my current permissions). I'll click merge when that passes but feel free to force-merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants