Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3527 Update to docs for IFU outlier detection #8360

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

jemorrison
Copy link
Collaborator

@jemorrison jemorrison commented Mar 13, 2024

Resolves JP-3527

Closes #8250

This PR updates the IFU outlier docs. I also updated some comments in the ifu_outlier code to make things more clear.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@jemorrison jemorrison added this to the Build 10.2 milestone Mar 13, 2024
@jemorrison jemorrison requested a review from a team as a code owner March 13, 2024 19:11
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.35%. Comparing base (2fb073e) to head (e289857).
Report is 1 commits behind head on master.

❗ Current head e289857 differs from pull request most recent head a498ca2. Consider uploading reports for the commit a498ca2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8360      +/-   ##
==========================================
+ Coverage   75.31%   75.35%   +0.04%     
==========================================
  Files         474      474              
  Lines       38965    38944      -21     
==========================================
+ Hits        29345    29348       +3     
+ Misses       9620     9596      -24     
Flag Coverage Δ *Carryforward flag
nightly 77.33% <ø> (-0.01%) ⬇️ Carriedforward from 4cc0ac1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES.rst Outdated Show resolved Hide resolved
docs/jwst/outlier_detection/outlier_detection_ifu.rst Outdated Show resolved Hide resolved
docs/jwst/outlier_detection/outlier_detection_ifu.rst Outdated Show resolved Hide resolved
jwst/outlier_detection/outlier_detection_ifu.py Outdated Show resolved Hide resolved
@hbushouse
Copy link
Collaborator

@jemorrison If you can address the review comments we can get this merged.

@jemorrison
Copy link
Collaborator Author

@hbushouse Changes from review have been made

docs/jwst/outlier_detection/outlier_detection_ifu.rst Outdated Show resolved Hide resolved
jwst/outlier_detection/outlier_detection_ifu.py Outdated Show resolved Hide resolved
@hbushouse hbushouse merged commit e1b0772 into spacetelescope:master Mar 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update IFU outlier detection in readthedocs
2 participants