-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-2943:Level_3 error: cannot reshape array in image3 pipeline #8305
JP-2943:Level_3 error: cannot reshape array in image3 pipeline #8305
Conversation
… outlier_detection step of image3 pipeline
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8305 +/- ##
==========================================
+ Coverage 75.15% 75.30% +0.14%
==========================================
Files 470 474 +4
Lines 38604 38992 +388
==========================================
+ Hits 29014 29363 +349
- Misses 9590 9629 +39
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… outlier_detection step of image3 pipeline
Full regression run on PR branch here: |
…ut_i2d files are written fully to disk before proceding
Co-authored-by: Ned Molter <[email protected]>
…jp2943_corrupted_file
…ggered by nonzero status return
@stscirij Latest updates look good. Please do another full regtest run to make sure none of the recent changes have messed up anything. |
Developer regtest here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1324/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Regtest results are clean.
Added code to try and solve intermittent problem of corrupted files in outlier_detection step of image3 pipeline
Resolves JP-2943
Closes #7271
This PR addresses problems noted in operations when running the image3 pipeline. During the outlier_rejection step,
data read from files written during the step appear corrupted. This is probably because the I/O has not fully completed when the file is accessed later in processing. To try and fix this, the file is read back in after a delay and the shape of the array in the data read back is compared to the shape of the data in the model that was written. If they are the same, processing continues. If they aren't, the output file is deleted, the delay doubled, and the readback/compare loop repeated. If the wait time exceeds 40s, processing continues with a warning that the file may be corrupted.
This change occurs in the resample step, and only if in_memory processing is not selected.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR