Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2943:Level_3 error: cannot reshape array in image3 pipeline #8305

Merged
merged 11 commits into from
Mar 19, 2024

Conversation

stscirij
Copy link
Contributor

@stscirij stscirij commented Feb 22, 2024

Added code to try and solve intermittent problem of corrupted files in outlier_detection step of image3 pipeline

Resolves JP-2943

Closes #7271

This PR addresses problems noted in operations when running the image3 pipeline. During the outlier_rejection step,
data read from files written during the step appear corrupted. This is probably because the I/O has not fully completed when the file is accessed later in processing. To try and fix this, the file is read back in after a delay and the shape of the array in the data read back is compared to the shape of the data in the model that was written. If they are the same, processing continues. If they aren't, the output file is deleted, the delay doubled, and the readback/compare loop repeated. If the wait time exceeds 40s, processing continues with a warning that the file may be corrupted.
This change occurs in the resample step, and only if in_memory processing is not selected.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@stscirij stscirij requested a review from a team as a code owner February 22, 2024 19:55
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 75.30%. Comparing base (4cc0ac1) to head (2d8454a).
Report is 31 commits behind head on master.

❗ Current head 2d8454a differs from pull request most recent head adb6075. Consider uploading reports for the commit adb6075 to get more accurate results

Files Patch % Lines
jwst/resample/resample.py 68.96% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8305      +/-   ##
==========================================
+ Coverage   75.15%   75.30%   +0.14%     
==========================================
  Files         470      474       +4     
  Lines       38604    38992     +388     
==========================================
+ Hits        29014    29363     +349     
- Misses       9590     9629      +39     
Flag Coverage Δ *Carryforward flag
nightly 77.33% <ø> (-0.06%) ⬇️ Carriedforward from 0066901

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stscirij
Copy link
Contributor Author

Full regression run on PR branch here:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1229/

CHANGES.rst Outdated Show resolved Hide resolved
jwst/resample/resample.py Outdated Show resolved Hide resolved
jwst/resample/resample.py Outdated Show resolved Hide resolved
@hbushouse hbushouse added this to the Build 10.2 milestone Mar 13, 2024
@hbushouse
Copy link
Collaborator

@stscirij Latest updates look good. Please do another full regtest run to make sure none of the recent changes have messed up anything.

@stscirij
Copy link
Contributor Author

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Regtest results are clean.

@hbushouse hbushouse merged commit 01a807b into spacetelescope:master Mar 19, 2024
25 checks passed
braingram added a commit to braingram/jwst that referenced this pull request Apr 10, 2024
@braingram braingram mentioned this pull request Apr 10, 2024
7 tasks
braingram added a commit to braingram/jwst that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Level_3 error: cannot reshape array. can be rescued without a needed repair
3 participants