JP-3533 Update emicorr to run on FAST mode MIRI data #8270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8270 +/- ##
==========================================
- Coverage 75.31% 75.27% -0.04%
==========================================
Files 474 474
Lines 38965 38971 +6
==========================================
- Hits 29345 29335 -10
- Misses 9620 9636 +16
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@penaguerrero Is this still WIP or is it ready for review? |
|
From my side it is ready but I was waiting to hear confirmation from Misty that it is indeed what they want. |
penaguerrero
changed the title
penaguerrero
force-pushed
the
emicorrfix
branch
from
39bdeaf
to
0b4da12
Compare
hbushouse
reviewed
Feb 27, 2024
|
Regression test run? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3533
Closes #8264
This PR addresses the behavior of the emicorr step. Previously it would run always for all MIRI data. The MIRI team requested it is skipped when no reference file is found and to add a parameter to allow the user to run the step for given frequencies with an on-the-fly generated reference file.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR